| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287428842894290429142924293429442954296429742984299430043014302430343044305430643074308430943104311431243134314431543164317431843194320432143224323432443254326432743284329433043314332433343344335433643374338433943404341434243434344434543464347434843494350435143524353435443554356435743584359436043614362436343644365436643674368436943704371437243734374437543764377437843794380438143824383438443854386438743884389439043914392439343944395439643974398439944004401440244034404440544064407440844094410441144124413441444154416441744184419442044214422442344244425442644274428442944304431443244334434443544364437443844394440444144424443444444454446444744484449445044514452445344544455445644574458445944604461446244634464446544664467446844694470447144724473447444754476447744784479448044814482448344844485448644874488448944904491449244934494449544964497449844994500450145024503450445054506450745084509451045114512451345144515451645174518451945204521452245234524452545264527452845294530453145324533453445354536453745384539454045414542454345444545454645474548454945504551455245534554455545564557455845594560456145624563456445654566456745684569457045714572457345744575457645774578457945804581458245834584458545864587458845894590459145924593459445954596459745984599460046014602460346044605460646074608460946104611461246134614461546164617461846194620462146224623462446254626462746284629463046314632463346344635 |
- package genopenapi
- import (
- "encoding/json"
- "errors"
- "fmt"
- "math"
- "reflect"
- "strings"
- "testing"
- "git.ikuban.com/server/swagger-api/protoc-gen-openapiv2/internal/descriptor"
- "git.ikuban.com/server/swagger-api/protoc-gen-openapiv2/internal/descriptor/openapiconfig"
- "git.ikuban.com/server/swagger-api/protoc-gen-openapiv2/internal/httprule"
- "github.com/google/go-cmp/cmp"
- openapi_options "github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options"
- "github.com/grpc-ecosystem/grpc-gateway/v2/runtime"
- "google.golang.org/genproto/googleapis/api/annotations"
- "google.golang.org/genproto/protobuf/field_mask"
- "google.golang.org/protobuf/proto"
- "google.golang.org/protobuf/reflect/protodesc"
- "google.golang.org/protobuf/types/descriptorpb"
- "google.golang.org/protobuf/types/known/durationpb"
- "google.golang.org/protobuf/types/known/structpb"
- "google.golang.org/protobuf/types/known/timestamppb"
- "google.golang.org/protobuf/types/known/wrapperspb"
- "google.golang.org/protobuf/types/pluginpb"
- )
- var marshaler = &runtime.JSONPb{}
- func crossLinkFixture(f *descriptor.File) *descriptor.File {
- for _, m := range f.Messages {
- m.File = f
- }
- for _, svc := range f.Services {
- svc.File = f
- for _, m := range svc.Methods {
- m.Service = svc
- for _, b := range m.Bindings {
- b.Method = m
- for _, param := range b.PathParams {
- param.Method = m
- }
- }
- }
- }
- return f
- }
- func reqFromFile(f *descriptor.File) *pluginpb.CodeGeneratorRequest {
- return &pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{
- f.FileDescriptorProto,
- },
- FileToGenerate: []string{f.GetName()},
- }
- }
- func TestMessageToQueryParametersWithEnumAsInt(t *testing.T) {
- type test struct {
- MsgDescs []*descriptorpb.DescriptorProto
- Message string
- Params []openapiParameterObject
- }
- tests := []test{
- {
- MsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("a"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("b"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_DOUBLE.Enum(),
- Number: proto.Int32(2),
- },
- {
- Name: proto.String("c"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REPEATED.Enum(),
- Number: proto.Int32(3),
- },
- },
- },
- },
- Message: "ExampleMessage",
- Params: []openapiParameterObject{
- {
- Name: "a",
- In: "query",
- Required: false,
- Type: "string",
- },
- {
- Name: "b",
- In: "query",
- Required: false,
- Type: "number",
- Format: "double",
- },
- {
- Name: "c",
- In: "query",
- Required: false,
- Type: "array",
- CollectionFormat: "multi",
- },
- },
- },
- {
- MsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("nested"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.Nested"),
- Number: proto.Int32(1),
- },
- },
- },
- {
- Name: proto.String("Nested"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("a"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("deep"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.Nested.DeepNested"),
- Number: proto.Int32(2),
- },
- },
- NestedType: []*descriptorpb.DescriptorProto{{
- Name: proto.String("DeepNested"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("b"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("c"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_ENUM.Enum(),
- TypeName: proto.String(".example.Nested.DeepNested.DeepEnum"),
- Number: proto.Int32(2),
- },
- },
- EnumType: []*descriptorpb.EnumDescriptorProto{
- {
- Name: proto.String("DeepEnum"),
- Value: []*descriptorpb.EnumValueDescriptorProto{
- {Name: proto.String("FALSE"), Number: proto.Int32(0)},
- {Name: proto.String("TRUE"), Number: proto.Int32(1)},
- },
- },
- },
- }},
- },
- },
- Message: "ExampleMessage",
- Params: []openapiParameterObject{
- {
- Name: "nested.a",
- In: "query",
- Required: false,
- Type: "string",
- },
- {
- Name: "nested.deep.b",
- In: "query",
- Required: false,
- Type: "string",
- },
- {
- Name: "nested.deep.c",
- In: "query",
- Required: false,
- Type: "integer",
- Enum: []string{"0", "1"},
- Default: "0",
- },
- },
- },
- }
- for _, test := range tests {
- reg := descriptor.NewRegistry()
- reg.SetEnumsAsInts(true)
- msgs := []*descriptor.Message{}
- for _, msgdesc := range test.MsgDescs {
- msgs = append(msgs, &descriptor.Message{DescriptorProto: msgdesc})
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- Dependency: []string{},
- MessageType: test.MsgDescs,
- Service: []*descriptorpb.ServiceDescriptorProto{},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: msgs,
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto},
- })
- if err != nil {
- t.Fatalf("failed to load code generator request: %v", err)
- }
- message, err := reg.LookupMsg("", ".example."+test.Message)
- if err != nil {
- t.Fatalf("failed to lookup message: %s", err)
- }
- params, err := messageToQueryParameters(message, reg, []descriptor.Parameter{}, nil)
- if err != nil {
- t.Fatalf("failed to convert message to query parameters: %s", err)
- }
- // avoid checking Items for array types
- for i := range params {
- params[i].Items = nil
- }
- if !reflect.DeepEqual(params, test.Params) {
- t.Errorf("expected %v, got %v", test.Params, params)
- }
- }
- }
- func TestMessageToQueryParameters(t *testing.T) {
- type test struct {
- MsgDescs []*descriptorpb.DescriptorProto
- Message string
- Params []openapiParameterObject
- }
- tests := []test{
- {
- MsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("a"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("b"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_DOUBLE.Enum(),
- Number: proto.Int32(2),
- },
- {
- Name: proto.String("c"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REPEATED.Enum(),
- Number: proto.Int32(3),
- },
- },
- },
- },
- Message: "ExampleMessage",
- Params: []openapiParameterObject{
- {
- Name: "a",
- In: "query",
- Required: false,
- Type: "string",
- },
- {
- Name: "b",
- In: "query",
- Required: false,
- Type: "number",
- Format: "double",
- },
- {
- Name: "c",
- In: "query",
- Required: false,
- Type: "array",
- CollectionFormat: "multi",
- },
- },
- },
- {
- MsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("nested"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.Nested"),
- Number: proto.Int32(1),
- },
- },
- },
- {
- Name: proto.String("Nested"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("a"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("deep"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.Nested.DeepNested"),
- Number: proto.Int32(2),
- },
- },
- NestedType: []*descriptorpb.DescriptorProto{{
- Name: proto.String("DeepNested"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("b"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("c"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_ENUM.Enum(),
- TypeName: proto.String(".example.Nested.DeepNested.DeepEnum"),
- Number: proto.Int32(2),
- },
- },
- EnumType: []*descriptorpb.EnumDescriptorProto{
- {
- Name: proto.String("DeepEnum"),
- Value: []*descriptorpb.EnumValueDescriptorProto{
- {Name: proto.String("FALSE"), Number: proto.Int32(0)},
- {Name: proto.String("TRUE"), Number: proto.Int32(1)},
- },
- },
- },
- }},
- },
- },
- Message: "ExampleMessage",
- Params: []openapiParameterObject{
- {
- Name: "nested.a",
- In: "query",
- Required: false,
- Type: "string",
- },
- {
- Name: "nested.deep.b",
- In: "query",
- Required: false,
- Type: "string",
- },
- {
- Name: "nested.deep.c",
- In: "query",
- Required: false,
- Type: "string",
- Enum: []string{"FALSE", "TRUE"},
- Default: "FALSE",
- },
- },
- },
- }
- for _, test := range tests {
- reg := descriptor.NewRegistry()
- msgs := []*descriptor.Message{}
- for _, msgdesc := range test.MsgDescs {
- msgs = append(msgs, &descriptor.Message{DescriptorProto: msgdesc})
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- Dependency: []string{},
- MessageType: test.MsgDescs,
- Service: []*descriptorpb.ServiceDescriptorProto{},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: msgs,
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto},
- })
- if err != nil {
- t.Fatalf("failed to load code generator request: %v", err)
- }
- message, err := reg.LookupMsg("", ".example."+test.Message)
- if err != nil {
- t.Fatalf("failed to lookup message: %s", err)
- }
- params, err := messageToQueryParameters(message, reg, []descriptor.Parameter{}, nil)
- if err != nil {
- t.Fatalf("failed to convert message to query parameters: %s", err)
- }
- // avoid checking Items for array types
- for i := range params {
- params[i].Items = nil
- }
- if !reflect.DeepEqual(params, test.Params) {
- t.Errorf("expected %v, got %v", test.Params, params)
- }
- }
- }
- // TestMessagetoQueryParametersNoRecursive, is a check that cyclical references between messages
- //
- // are not falsely detected given previous known edge-cases.
- func TestMessageToQueryParametersNoRecursive(t *testing.T) {
- type test struct {
- MsgDescs []*descriptorpb.DescriptorProto
- Message string
- }
- tests := []test{
- // First test:
- // Here is a message that has two of another message adjacent to one another in a nested message.
- // There is no loop but this was previouly falsely flagged as a cycle.
- // Example proto:
- // message NonRecursiveMessage {
- // string field = 1;
- // }
- // message BaseMessage {
- // NonRecursiveMessage first = 1;
- // NonRecursiveMessage second = 2;
- // }
- // message QueryMessage {
- // BaseMessage first = 1;
- // string second = 2;
- // }
- {
- MsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("QueryMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("first"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.BaseMessage"),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("second"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(2),
- },
- },
- },
- {
- Name: proto.String("BaseMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("first"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.NonRecursiveMessage"),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("second"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.NonRecursiveMessage"),
- Number: proto.Int32(2),
- },
- },
- },
- // Note there is no recursive nature to this message
- {
- Name: proto.String("NonRecursiveMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("field"),
- //Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- },
- },
- },
- Message: "QueryMessage",
- },
- }
- for _, test := range tests {
- reg := descriptor.NewRegistry()
- msgs := []*descriptor.Message{}
- for _, msgdesc := range test.MsgDescs {
- msgs = append(msgs, &descriptor.Message{DescriptorProto: msgdesc})
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- Dependency: []string{},
- MessageType: test.MsgDescs,
- Service: []*descriptorpb.ServiceDescriptorProto{},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: msgs,
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto},
- })
- if err != nil {
- t.Fatalf("failed to load code generator request: %v", err)
- }
- message, err := reg.LookupMsg("", ".example."+test.Message)
- if err != nil {
- t.Fatalf("failed to lookup message: %s", err)
- }
- _, err = messageToQueryParameters(message, reg, []descriptor.Parameter{}, nil)
- if err != nil {
- t.Fatalf("No recursion error should be thrown: %s", err)
- }
- }
- }
- // TestMessagetoQueryParametersRecursive, is a check that cyclical references between messages
- //
- // are handled gracefully. The goal is to insure that attempts to add messages with cyclical
- // references to query-parameters returns an error message.
- func TestMessageToQueryParametersRecursive(t *testing.T) {
- type test struct {
- MsgDescs []*descriptorpb.DescriptorProto
- Message string
- }
- tests := []test{
- // First test:
- // Here we test that a message that references it self through a field will return an error.
- // Example proto:
- // message DirectRecursiveMessage {
- // DirectRecursiveMessage nested = 1;
- // }
- {
- MsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("DirectRecursiveMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("nested"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.DirectRecursiveMessage"),
- Number: proto.Int32(1),
- },
- },
- },
- },
- Message: "DirectRecursiveMessage",
- },
- // Second test:
- // Here we test that a cycle through multiple messages is detected and that an error is returned.
- // Sample:
- // message Root { NodeMessage nested = 1; }
- // message NodeMessage { CycleMessage nested = 1; }
- // message CycleMessage { Root nested = 1; }
- {
- MsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("RootMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("nested"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.NodeMessage"),
- Number: proto.Int32(1),
- },
- },
- },
- {
- Name: proto.String("NodeMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("nested"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.CycleMessage"),
- Number: proto.Int32(1),
- },
- },
- },
- {
- Name: proto.String("CycleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("nested"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.RootMessage"),
- Number: proto.Int32(1),
- },
- },
- },
- },
- Message: "RootMessage",
- },
- }
- for _, test := range tests {
- reg := descriptor.NewRegistry()
- msgs := []*descriptor.Message{}
- for _, msgdesc := range test.MsgDescs {
- msgs = append(msgs, &descriptor.Message{DescriptorProto: msgdesc})
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- Dependency: []string{},
- MessageType: test.MsgDescs,
- Service: []*descriptorpb.ServiceDescriptorProto{},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: msgs,
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto},
- })
- if err != nil {
- t.Fatalf("failed to load code generator request: %v", err)
- }
- message, err := reg.LookupMsg("", ".example."+test.Message)
- if err != nil {
- t.Fatalf("failed to lookup message: %s", err)
- }
- _, err = messageToQueryParameters(message, reg, []descriptor.Parameter{}, nil)
- if err == nil {
- t.Fatalf("It should not be allowed to have recursive query parameters")
- }
- }
- }
- func TestMessageToQueryParametersWithJsonName(t *testing.T) {
- type test struct {
- MsgDescs []*descriptorpb.DescriptorProto
- Message string
- Params []openapiParameterObject
- }
- tests := []test{
- {
- MsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("test_field_a"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- JsonName: proto.String("testFieldA"),
- },
- },
- },
- },
- Message: "ExampleMessage",
- Params: []openapiParameterObject{
- {
- Name: "testFieldA",
- In: "query",
- Required: false,
- Type: "string",
- },
- },
- },
- {
- MsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("SubMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("test_field_a"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- JsonName: proto.String("testFieldA"),
- },
- },
- },
- {
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("sub_message"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.SubMessage"),
- Number: proto.Int32(1),
- JsonName: proto.String("subMessage"),
- },
- },
- },
- },
- Message: "ExampleMessage",
- Params: []openapiParameterObject{
- {
- Name: "subMessage.testFieldA",
- In: "query",
- Required: false,
- Type: "string",
- },
- },
- },
- }
- for _, test := range tests {
- reg := descriptor.NewRegistry()
- reg.SetUseJSONNamesForFields(true)
- msgs := []*descriptor.Message{}
- for _, msgdesc := range test.MsgDescs {
- msgs = append(msgs, &descriptor.Message{DescriptorProto: msgdesc})
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- Dependency: []string{},
- MessageType: test.MsgDescs,
- Service: []*descriptorpb.ServiceDescriptorProto{},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: msgs,
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto},
- })
- if err != nil {
- t.Fatalf("failed to load code generator request: %v", err)
- }
- message, err := reg.LookupMsg("", ".example."+test.Message)
- if err != nil {
- t.Fatalf("failed to lookup message: %s", err)
- }
- params, err := messageToQueryParameters(message, reg, []descriptor.Parameter{}, nil)
- if err != nil {
- t.Fatalf("failed to convert message to query parameters: %s", err)
- }
- if !reflect.DeepEqual(params, test.Params) {
- t.Errorf("expected %v, got %v", test.Params, params)
- }
- }
- }
- func TestMessageToQueryParametersWellKnownTypes(t *testing.T) {
- type test struct {
- MsgDescs []*descriptorpb.DescriptorProto
- WellKnownMsgDescs []*descriptorpb.DescriptorProto
- Message string
- Params []openapiParameterObject
- }
- tests := []test{
- {
- MsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("a_field_mask"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".google.protobuf.FieldMask"),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("a_timestamp"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".google.protobuf.Timestamp"),
- Number: proto.Int32(2),
- },
- },
- },
- },
- WellKnownMsgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("FieldMask"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("paths"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REPEATED.Enum(),
- Number: proto.Int32(1),
- },
- },
- },
- {
- Name: proto.String("Timestamp"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("seconds"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_INT64.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("nanos"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_INT32.Enum(),
- Number: proto.Int32(2),
- },
- },
- },
- },
- Message: "ExampleMessage",
- Params: []openapiParameterObject{
- {
- Name: "a_field_mask",
- In: "query",
- Required: false,
- Type: "string",
- },
- {
- Name: "a_timestamp",
- In: "query",
- Required: false,
- Type: "string",
- Format: "date-time",
- },
- },
- },
- }
- for _, test := range tests {
- reg := descriptor.NewRegistry()
- reg.SetEnumsAsInts(true)
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{
- {
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("google/well_known.proto"),
- Package: proto.String("google.protobuf"),
- Dependency: []string{},
- MessageType: test.WellKnownMsgDescs,
- Service: []*descriptorpb.ServiceDescriptorProto{},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("google/well_known"),
- },
- },
- {
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("acme/example.proto"),
- Package: proto.String("example"),
- Dependency: []string{"google/well_known.proto"},
- MessageType: test.MsgDescs,
- Service: []*descriptorpb.ServiceDescriptorProto{},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("acme/example"),
- },
- },
- },
- })
- if err != nil {
- t.Fatalf("failed to load CodeGeneratorRequest: %v", err)
- }
- message, err := reg.LookupMsg("", ".example."+test.Message)
- if err != nil {
- t.Fatalf("failed to lookup message: %s", err)
- }
- params, err := messageToQueryParameters(message, reg, []descriptor.Parameter{}, nil)
- if err != nil {
- t.Fatalf("failed to convert message to query parameters: %s", err)
- }
- if !reflect.DeepEqual(params, test.Params) {
- t.Errorf("expected %v, got %v", test.Params, params)
- }
- }
- }
- func TestApplyTemplateSimple(t *testing.T) {
- msgdesc := &descriptorpb.DescriptorProto{
- Name: proto.String("ExampleMessage"),
- }
- meth := &descriptorpb.MethodDescriptorProto{
- Name: proto.String("Example"),
- InputType: proto.String("ExampleMessage"),
- OutputType: proto.String("ExampleMessage"),
- }
- svc := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("ExampleService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- msg := &descriptor.Message{
- DescriptorProto: msgdesc,
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- MessageType: []*descriptorpb.DescriptorProto{msgdesc},
- Service: []*descriptorpb.ServiceDescriptorProto{svc},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: []*descriptor.Message{msg},
- Services: []*descriptor.Service{
- {
- ServiceDescriptorProto: svc,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: msg,
- ResponseType: msg,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "GET",
- Body: &descriptor.Body{FieldPath: nil},
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/echo", // TODO(achew22): Figure out what this should really be
- },
- },
- },
- },
- },
- },
- },
- }
- reg := descriptor.NewRegistry()
- if err := AddErrorDefs(reg); err != nil {
- t.Errorf("AddErrorDefs(%#v) failed with %v; want success", reg, err)
- return
- }
- fileCL := crossLinkFixture(&file)
- err := reg.Load(reqFromFile(fileCL))
- if err != nil {
- t.Errorf("reg.Load(%#v) failed with %v; want success", file, err)
- return
- }
- result, err := applyTemplate(param{File: fileCL, reg: reg})
- if err != nil {
- t.Errorf("applyTemplate(%#v) failed with %v; want success", file, err)
- return
- }
- if want, is, name := "2.0", result.Swagger, "Swagger"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- if want, is, name := "", result.BasePath, "BasePath"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- if want, is, name := ([]string)(nil), result.Schemes, "Schemes"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- if want, is, name := []string{"application/json"}, result.Consumes, "Consumes"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- if want, is, name := []string{"application/json"}, result.Produces, "Produces"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- // If there was a failure, print out the input and the json result for debugging.
- if t.Failed() {
- t.Errorf("had: %s", file)
- t.Errorf("got: %s", fmt.Sprint(result))
- }
- }
- func TestApplyTemplateMultiService(t *testing.T) {
- msgdesc := &descriptorpb.DescriptorProto{
- Name: proto.String("ExampleMessage"),
- }
- meth := &descriptorpb.MethodDescriptorProto{
- Name: proto.String("Example"),
- InputType: proto.String("ExampleMessage"),
- OutputType: proto.String("ExampleMessage"),
- }
- // Create two services that have the same method name. We will test that the
- // operation IDs are different
- svc := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("ExampleService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- svc2 := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("OtherService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- msg := &descriptor.Message{
- DescriptorProto: msgdesc,
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- MessageType: []*descriptorpb.DescriptorProto{msgdesc},
- Service: []*descriptorpb.ServiceDescriptorProto{svc},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: []*descriptor.Message{msg},
- Services: []*descriptor.Service{
- {
- ServiceDescriptorProto: svc,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: msg,
- ResponseType: msg,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "GET",
- Body: &descriptor.Body{FieldPath: nil},
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/echo",
- },
- },
- },
- },
- },
- },
- {
- ServiceDescriptorProto: svc2,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: msg,
- ResponseType: msg,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "GET",
- Body: &descriptor.Body{FieldPath: nil},
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/ping",
- },
- },
- },
- },
- },
- },
- },
- }
- reg := descriptor.NewRegistry()
- if err := AddErrorDefs(reg); err != nil {
- t.Errorf("AddErrorDefs(%#v) failed with %v; want success", reg, err)
- return
- }
- fileCL := crossLinkFixture(&file)
- err := reg.Load(reqFromFile(fileCL))
- if err != nil {
- t.Errorf("reg.Load(%#v) failed with %v; want success", file, err)
- return
- }
- result, err := applyTemplate(param{File: fileCL, reg: reg})
- if err != nil {
- t.Errorf("applyTemplate(%#v) failed with %v; want success", file, err)
- return
- }
- // Check that the two services have unique operation IDs even though they
- // have the same method name.
- if want, is := "ExampleService_Example", result.Paths["/v1/echo"].Get.OperationID; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).Paths[0].Get.OperationID = %s want to be %s", file, is, want)
- }
- if want, is := "OtherService_Example", result.Paths["/v1/ping"].Get.OperationID; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).Paths[0].Get.OperationID = %s want to be %s", file, is, want)
- }
- // If there was a failure, print out the input and the json result for debugging.
- if t.Failed() {
- t.Errorf("had: %s", file)
- t.Errorf("got: %s", fmt.Sprint(result))
- }
- }
- func TestApplyTemplateOverrideOperationID(t *testing.T) {
- newFile := func() *descriptor.File {
- msgdesc := &descriptorpb.DescriptorProto{
- Name: proto.String("ExampleMessage"),
- }
- meth := &descriptorpb.MethodDescriptorProto{
- Name: proto.String("Example"),
- InputType: proto.String("ExampleMessage"),
- OutputType: proto.String("ExampleMessage"),
- Options: &descriptorpb.MethodOptions{},
- }
- svc := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("ExampleService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- msg := &descriptor.Message{
- DescriptorProto: msgdesc,
- }
- return &descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- MessageType: []*descriptorpb.DescriptorProto{msgdesc},
- Service: []*descriptorpb.ServiceDescriptorProto{svc},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: []*descriptor.Message{msg},
- Services: []*descriptor.Service{
- {
- ServiceDescriptorProto: svc,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: msg,
- ResponseType: msg,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "GET",
- Body: &descriptor.Body{FieldPath: nil},
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/echo", // TODO(achew22): Figure out what this should really be
- },
- },
- },
- },
- },
- },
- },
- }
- }
- verifyTemplateFromReq := func(t *testing.T, reg *descriptor.Registry, file *descriptor.File, opts *openapiconfig.OpenAPIOptions) {
- if err := AddErrorDefs(reg); err != nil {
- t.Errorf("AddErrorDefs(%#v) failed with %v; want success", reg, err)
- return
- }
- fileCL := crossLinkFixture(file)
- err := reg.Load(reqFromFile(fileCL))
- if err != nil {
- t.Errorf("reg.Load(%#v) failed with %v; want success", *file, err)
- return
- }
- if opts != nil {
- if err := reg.RegisterOpenAPIOptions(opts); err != nil {
- t.Fatalf("failed to register OpenAPI options: %s", err)
- }
- }
- result, err := applyTemplate(param{File: fileCL, reg: reg})
- if err != nil {
- t.Errorf("applyTemplate(%#v) failed with %v; want success", *file, err)
- return
- }
- if want, is := "MyExample", result.Paths["/v1/echo"].Get.OperationID; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).Paths[0].Get.OperationID = %s want to be %s", *file, is, want)
- }
- // If there was a failure, print out the input and the json result for debugging.
- if t.Failed() {
- t.Errorf("had: %s", *file)
- t.Errorf("got: %s", fmt.Sprint(result))
- }
- }
- openapiOperation := openapi_options.Operation{
- OperationId: "MyExample",
- }
- t.Run("verify override via method option", func(t *testing.T) {
- file := newFile()
- proto.SetExtension(proto.Message(file.Services[0].Methods[0].MethodDescriptorProto.Options),
- openapi_options.E_Openapiv2Operation, &openapiOperation)
- reg := descriptor.NewRegistry()
- verifyTemplateFromReq(t, reg, file, nil)
- })
- t.Run("verify override options annotations", func(t *testing.T) {
- file := newFile()
- reg := descriptor.NewRegistry()
- opts := &openapiconfig.OpenAPIOptions{
- Method: []*openapiconfig.OpenAPIMethodOption{
- {
- Method: "example.ExampleService.Example",
- Option: &openapiOperation,
- },
- },
- }
- verifyTemplateFromReq(t, reg, file, opts)
- })
- }
- func TestApplyTemplateExtensions(t *testing.T) {
- newFile := func() *descriptor.File {
- msgdesc := &descriptorpb.DescriptorProto{
- Name: proto.String("ExampleMessage"),
- }
- meth := &descriptorpb.MethodDescriptorProto{
- Name: proto.String("Example"),
- InputType: proto.String("ExampleMessage"),
- OutputType: proto.String("ExampleMessage"),
- Options: &descriptorpb.MethodOptions{},
- }
- svc := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("ExampleService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- msg := &descriptor.Message{
- DescriptorProto: msgdesc,
- }
- return &descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- MessageType: []*descriptorpb.DescriptorProto{msgdesc},
- Service: []*descriptorpb.ServiceDescriptorProto{svc},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: []*descriptor.Message{msg},
- Services: []*descriptor.Service{
- {
- ServiceDescriptorProto: svc,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: msg,
- ResponseType: msg,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "GET",
- Body: &descriptor.Body{FieldPath: nil},
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/echo", // TODO(achew22): Figure out what this should really be
- },
- },
- },
- },
- },
- },
- },
- }
- }
- swagger := openapi_options.Swagger{
- Info: &openapi_options.Info{
- Title: "test",
- Extensions: map[string]*structpb.Value{
- "x-info-extension": {Kind: &structpb.Value_StringValue{StringValue: "bar"}},
- },
- },
- Extensions: map[string]*structpb.Value{
- "x-foo": {Kind: &structpb.Value_StringValue{StringValue: "bar"}},
- "x-bar": {Kind: &structpb.Value_ListValue{ListValue: &structpb.ListValue{
- Values: []*structpb.Value{{Kind: &structpb.Value_StringValue{StringValue: "baz"}}},
- }}},
- },
- SecurityDefinitions: &openapi_options.SecurityDefinitions{
- Security: map[string]*openapi_options.SecurityScheme{
- "somescheme": {
- Extensions: map[string]*structpb.Value{
- "x-security-baz": {Kind: &structpb.Value_BoolValue{BoolValue: true}},
- },
- },
- },
- },
- }
- openapiOperation := openapi_options.Operation{
- Responses: map[string]*openapi_options.Response{
- "200": {
- Extensions: map[string]*structpb.Value{
- "x-resp-id": {Kind: &structpb.Value_StringValue{StringValue: "resp1000"}},
- },
- },
- },
- Extensions: map[string]*structpb.Value{
- "x-op-foo": {Kind: &structpb.Value_StringValue{StringValue: "baz"}},
- },
- }
- verifyTemplateExtensions := func(t *testing.T, reg *descriptor.Registry, file *descriptor.File,
- opts *openapiconfig.OpenAPIOptions) {
- if err := AddErrorDefs(reg); err != nil {
- t.Errorf("AddErrorDefs(%#v) failed with %v; want success", reg, err)
- return
- }
- fileCL := crossLinkFixture(file)
- err := reg.Load(reqFromFile(fileCL))
- if err != nil {
- t.Errorf("reg.Load(%#v) failed with %v; want success", file, err)
- return
- }
- if opts != nil {
- if err := reg.RegisterOpenAPIOptions(opts); err != nil {
- t.Fatalf("failed to register OpenAPI annotations: %s", err)
- }
- }
- result, err := applyTemplate(param{File: fileCL, reg: reg})
- if err != nil {
- t.Errorf("applyTemplate(%#v) failed with %v; want success", file, err)
- return
- }
- if want, is, name := "2.0", result.Swagger, "Swagger"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- if got, want := len(result.extensions), 2; got != want {
- t.Fatalf("len(applyTemplate(%#v).Extensions) = %d want to be %d", file, got, want)
- }
- if got, want := result.extensions[0].key, "x-bar"; got != want {
- t.Errorf("applyTemplate(%#v).Extensions[0].key = %s want to be %s", file, got, want)
- }
- if got, want := result.extensions[1].key, "x-foo"; got != want {
- t.Errorf("applyTemplate(%#v).Extensions[1].key = %s want to be %s", file, got, want)
- }
- {
- var got []string
- err = marshaler.Unmarshal(result.extensions[0].value, &got)
- if err != nil {
- t.Fatalf("marshaler.Unmarshal failed: %v", err)
- }
- want := []string{"baz"}
- if diff := cmp.Diff(got, want); diff != "" {
- t.Errorf(diff)
- }
- }
- {
- var got string
- err = marshaler.Unmarshal(result.extensions[1].value, &got)
- if err != nil {
- t.Fatalf("marshaler.Unmarshal failed: %v", err)
- }
- want := "bar"
- if diff := cmp.Diff(got, want); diff != "" {
- t.Errorf(diff)
- }
- }
- var scheme openapiSecuritySchemeObject
- for _, v := range result.SecurityDefinitions {
- scheme = v
- }
- if want, is, name := []extension{
- {key: "x-security-baz", value: json.RawMessage("true")},
- }, scheme.extensions, "SecurityScheme.Extensions"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- if want, is, name := []extension{
- {key: "x-info-extension", value: json.RawMessage("\"bar\"")},
- }, result.Info.extensions, "Info.Extensions"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- var operation *openapiOperationObject
- var response openapiResponseObject
- for _, v := range result.Paths {
- operation = v.Get
- response = v.Get.Responses["200"]
- }
- if want, is, name := []extension{
- {key: "x-op-foo", value: json.RawMessage("\"baz\"")},
- }, operation.extensions, "operation.Extensions"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- if want, is, name := []extension{
- {key: "x-resp-id", value: json.RawMessage("\"resp1000\"")},
- }, response.extensions, "response.Extensions"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- }
- t.Run("verify template options set via proto options", func(t *testing.T) {
- file := newFile()
- proto.SetExtension(proto.Message(file.FileDescriptorProto.Options), openapi_options.E_Openapiv2Swagger, &swagger)
- proto.SetExtension(proto.Message(file.Services[0].Methods[0].Options), openapi_options.E_Openapiv2Operation, &openapiOperation)
- reg := descriptor.NewRegistry()
- verifyTemplateExtensions(t, reg, file, nil)
- })
- t.Run("verify template options set via annotations", func(t *testing.T) {
- file := newFile()
- opts := &openapiconfig.OpenAPIOptions{
- File: []*openapiconfig.OpenAPIFileOption{
- {
- File: "example.proto",
- Option: &swagger,
- },
- },
- Method: []*openapiconfig.OpenAPIMethodOption{
- {
- Method: "example.ExampleService.Example",
- Option: &openapiOperation,
- },
- },
- }
- reg := descriptor.NewRegistry()
- verifyTemplateExtensions(t, reg, file, opts)
- })
- }
- func TestApplyTemplateHeaders(t *testing.T) {
- newFile := func() *descriptor.File {
- msgdesc := &descriptorpb.DescriptorProto{
- Name: proto.String("ExampleMessage"),
- }
- meth := &descriptorpb.MethodDescriptorProto{
- Name: proto.String("Example"),
- InputType: proto.String("ExampleMessage"),
- OutputType: proto.String("ExampleMessage"),
- Options: &descriptorpb.MethodOptions{},
- }
- svc := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("ExampleService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- msg := &descriptor.Message{
- DescriptorProto: msgdesc,
- }
- return &descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- MessageType: []*descriptorpb.DescriptorProto{msgdesc},
- Service: []*descriptorpb.ServiceDescriptorProto{svc},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: []*descriptor.Message{msg},
- Services: []*descriptor.Service{
- {
- ServiceDescriptorProto: svc,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: msg,
- ResponseType: msg,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "GET",
- Body: &descriptor.Body{FieldPath: nil},
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/echo", // TODO(achew22): Figure out what this should really be
- },
- },
- },
- },
- },
- },
- },
- }
- }
- openapiOperation := openapi_options.Operation{
- Responses: map[string]*openapi_options.Response{
- "200": &openapi_options.Response{
- Description: "Testing Headers",
- Headers: map[string]*openapi_options.Header{
- "string": {
- Description: "string header description",
- Type: "string",
- Format: "uuid",
- Pattern: "",
- },
- "boolean": {
- Description: "boolean header description",
- Type: "boolean",
- Default: "true",
- Pattern: "^true|false$",
- },
- "integer": {
- Description: "integer header description",
- Type: "integer",
- Default: "0",
- Pattern: "^[0-9]$",
- },
- "number": {
- Description: "number header description",
- Type: "number",
- Default: "1.2",
- Pattern: "^[-+]?[0-9]*\\.?[0-9]+([eE][-+]?[0-9]+)?$",
- },
- },
- },
- },
- }
- verifyTemplateHeaders := func(t *testing.T, reg *descriptor.Registry, file *descriptor.File,
- opts *openapiconfig.OpenAPIOptions) {
- if err := AddErrorDefs(reg); err != nil {
- t.Errorf("AddErrorDefs(%#v) failed with %v; want success", reg, err)
- return
- }
- fileCL := crossLinkFixture(file)
- err := reg.Load(reqFromFile(fileCL))
- if err != nil {
- t.Errorf("reg.Load(%#v) failed with %v; want success", file, err)
- return
- }
- if opts != nil {
- if err := reg.RegisterOpenAPIOptions(opts); err != nil {
- t.Fatalf("failed to register OpenAPI annotations: %s", err)
- }
- }
- result, err := applyTemplate(param{File: fileCL, reg: reg})
- if err != nil {
- t.Errorf("applyTemplate(%#v) failed with %v; want success", file, err)
- return
- }
- if want, is, name := "2.0", result.Swagger, "Swagger"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- var response openapiResponseObject
- for _, v := range result.Paths {
- response = v.Get.Responses["200"]
- }
- if want, is, name := []openapiHeadersObject{
- {
- "String": openapiHeaderObject{
- Description: "string header description",
- Type: "string",
- Format: "uuid",
- Pattern: "",
- },
- "Boolean": openapiHeaderObject{
- Description: "boolean header description",
- Type: "boolean",
- Default: json.RawMessage("true"),
- Pattern: "^true|false$",
- },
- "Integer": openapiHeaderObject{
- Description: "integer header description",
- Type: "integer",
- Default: json.RawMessage("0"),
- Pattern: "^[0-9]$",
- },
- "Number": openapiHeaderObject{
- Description: "number header description",
- Type: "number",
- Default: json.RawMessage("1.2"),
- Pattern: "^[-+]?[0-9]*\\.?[0-9]+([eE][-+]?[0-9]+)?$",
- },
- },
- }[0], response.Headers, "response.Headers"; !reflect.DeepEqual(is, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, is, want)
- }
- }
- t.Run("verify template options set via proto options", func(t *testing.T) {
- file := newFile()
- proto.SetExtension(proto.Message(file.Services[0].Methods[0].Options), openapi_options.E_Openapiv2Operation, &openapiOperation)
- reg := descriptor.NewRegistry()
- verifyTemplateHeaders(t, reg, file, nil)
- })
- }
- func TestValidateHeaderType(t *testing.T) {
- type test struct {
- Type string
- Format string
- expectedError error
- }
- tests := []test{
- {
- "string",
- "date-time",
- nil,
- },
- {
- "boolean",
- "",
- nil,
- },
- {
- "integer",
- "uint",
- nil,
- },
- {
- "integer",
- "uint8",
- nil,
- },
- {
- "integer",
- "uint16",
- nil,
- },
- {
- "integer",
- "uint32",
- nil,
- },
- {
- "integer",
- "uint64",
- nil,
- },
- {
- "integer",
- "int",
- nil,
- },
- {
- "integer",
- "int8",
- nil,
- },
- {
- "integer",
- "int16",
- nil,
- },
- {
- "integer",
- "int32",
- nil,
- },
- {
- "integer",
- "int64",
- nil,
- },
- {
- "integer",
- "float64",
- errors.New("the provided format \"float64\" is not a valid extension of the type \"integer\""),
- },
- {
- "integer",
- "uuid",
- errors.New("the provided format \"uuid\" is not a valid extension of the type \"integer\""),
- },
- {
- "number",
- "uint",
- nil,
- },
- {
- "number",
- "uint8",
- nil,
- },
- {
- "number",
- "uint16",
- nil,
- },
- {
- "number",
- "uint32",
- nil,
- },
- {
- "number",
- "uint64",
- nil,
- },
- {
- "number",
- "int",
- nil,
- },
- {
- "number",
- "int8",
- nil,
- },
- {
- "number",
- "int16",
- nil,
- },
- {
- "number",
- "int32",
- nil,
- },
- {
- "number",
- "int64",
- nil,
- },
- {
- "number",
- "float",
- nil,
- },
- {
- "number",
- "float32",
- nil,
- },
- {
- "number",
- "float64",
- nil,
- },
- {
- "number",
- "complex64",
- nil,
- },
- {
- "number",
- "complex128",
- nil,
- },
- {
- "number",
- "double",
- nil,
- },
- {
- "number",
- "byte",
- nil,
- },
- {
- "number",
- "rune",
- nil,
- },
- {
- "number",
- "uintptr",
- nil,
- },
- {
- "number",
- "date",
- errors.New("the provided format \"date\" is not a valid extension of the type \"number\""),
- },
- {
- "array",
- "",
- errors.New("the provided header type \"array\" is not supported"),
- },
- {
- "foo",
- "",
- errors.New("the provided header type \"foo\" is not supported"),
- },
- }
- for _, v := range tests {
- err := validateHeaderTypeAndFormat(v.Type, v.Format)
- if v.expectedError == nil {
- if err != nil {
- t.Errorf("unexpected error %v", err)
- }
- } else {
- if err == nil {
- t.Fatal("expected header error not returned")
- }
- if err.Error() != v.expectedError.Error() {
- t.Errorf("expected error malformed, expected %q, got %q", v.expectedError.Error(), err.Error())
- }
- }
- }
- }
- func TestValidateDefaultValueType(t *testing.T) {
- type test struct {
- Type string
- Value string
- Format string
- expectedError error
- }
- tests := []test{
- {
- "string",
- `"string"`,
- "",
- nil,
- },
- {
- "string",
- "\"2012-11-01T22:08:41+00:00\"",
- "date-time",
- nil,
- },
- {
- "string",
- "\"2012-11-01\"",
- "date",
- nil,
- },
- {
- "string",
- "0",
- "",
- errors.New("the provided default value \"0\" does not match provider type \"string\", or is not properly quoted with escaped quotations"),
- },
- {
- "string",
- "false",
- "",
- errors.New("the provided default value \"false\" does not match provider type \"string\", or is not properly quoted with escaped quotations"),
- },
- {
- "boolean",
- "true",
- "",
- nil,
- },
- {
- "boolean",
- "0",
- "",
- errors.New("the provided default value \"0\" does not match provider type \"boolean\""),
- },
- {
- "boolean",
- `"string"`,
- "",
- errors.New("the provided default value \"\\\"string\\\"\" does not match provider type \"boolean\""),
- },
- {
- "number",
- "1.2",
- "",
- nil,
- },
- {
- "number",
- "123",
- "",
- nil,
- },
- {
- "number",
- "nan",
- "",
- errors.New("the provided number \"nan\" is not a valid JSON number"),
- },
- {
- "number",
- "NaN",
- "",
- errors.New("the provided number \"NaN\" is not a valid JSON number"),
- },
- {
- "number",
- "-459.67",
- "",
- nil,
- },
- {
- "number",
- "inf",
- "",
- errors.New("the provided number \"inf\" is not a valid JSON number"),
- },
- {
- "number",
- "infinity",
- "",
- errors.New("the provided number \"infinity\" is not a valid JSON number"),
- },
- {
- "number",
- "Inf",
- "",
- errors.New("the provided number \"Inf\" is not a valid JSON number"),
- },
- {
- "number",
- "Infinity",
- "",
- errors.New("the provided number \"Infinity\" is not a valid JSON number"),
- },
- {
- "number",
- "false",
- "",
- errors.New("the provided default value \"false\" does not match provider type \"number\""),
- },
- {
- "number",
- `"string"`,
- "",
- errors.New("the provided default value \"\\\"string\\\"\" does not match provider type \"number\""),
- },
- {
- "integer",
- "2",
- "",
- nil,
- },
- {
- "integer",
- fmt.Sprint(math.MaxInt32),
- "int32",
- nil,
- },
- {
- "integer",
- fmt.Sprint(math.MaxInt32 + 1),
- "int32",
- errors.New("the provided default value \"2147483648\" does not match provided format \"int32\""),
- },
- {
- "integer",
- fmt.Sprint(math.MaxInt64),
- "int64",
- nil,
- },
- {
- "integer",
- "9223372036854775808",
- "int64",
- errors.New("the provided default value \"9223372036854775808\" does not match provided format \"int64\""),
- },
- {
- "integer",
- "18446744073709551615",
- "uint64",
- nil,
- },
- {
- "integer",
- "false",
- "",
- errors.New("the provided default value \"false\" does not match provided type \"integer\""),
- },
- {
- "integer",
- "1.2",
- "",
- errors.New("the provided default value \"1.2\" does not match provided type \"integer\""),
- },
- {
- "integer",
- `"string"`,
- "",
- errors.New("the provided default value \"\\\"string\\\"\" does not match provided type \"integer\""),
- },
- }
- for _, v := range tests {
- err := validateDefaultValueTypeAndFormat(v.Type, v.Value, v.Format)
- if v.expectedError == nil {
- if err != nil {
- t.Errorf("unexpected error '%v'", err)
- }
- } else {
- if err == nil {
- t.Error("expected update error not returned")
- }
- if err.Error() != v.expectedError.Error() {
- t.Errorf("expected error malformed, expected %q, got %q", v.expectedError.Error(), err.Error())
- }
- }
- }
- }
- func TestApplyTemplateRequestWithoutClientStreaming(t *testing.T) {
- msgdesc := &descriptorpb.DescriptorProto{
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("nested"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String("NestedMessage"),
- Number: proto.Int32(1),
- },
- },
- }
- nesteddesc := &descriptorpb.DescriptorProto{
- Name: proto.String("NestedMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("int32"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_INT32.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("bool"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_BOOL.Enum(),
- Number: proto.Int32(2),
- },
- },
- }
- meth := &descriptorpb.MethodDescriptorProto{
- Name: proto.String("Echo"),
- InputType: proto.String("ExampleMessage"),
- OutputType: proto.String("ExampleMessage"),
- ClientStreaming: proto.Bool(false),
- }
- svc := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("ExampleService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- meth.ServerStreaming = proto.Bool(false)
- msg := &descriptor.Message{
- DescriptorProto: msgdesc,
- }
- nested := &descriptor.Message{
- DescriptorProto: nesteddesc,
- }
- nestedField := &descriptor.Field{
- Message: msg,
- FieldDescriptorProto: msg.GetField()[0],
- }
- intField := &descriptor.Field{
- Message: nested,
- FieldDescriptorProto: nested.GetField()[0],
- }
- boolField := &descriptor.Field{
- Message: nested,
- FieldDescriptorProto: nested.GetField()[1],
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- MessageType: []*descriptorpb.DescriptorProto{msgdesc, nesteddesc},
- Service: []*descriptorpb.ServiceDescriptorProto{svc},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: []*descriptor.Message{msg, nested},
- Services: []*descriptor.Service{
- {
- ServiceDescriptorProto: svc,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: msg,
- ResponseType: msg,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "POST",
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/echo", // TODO(achew): Figure out what this hsould really be
- },
- PathParams: []descriptor.Parameter{
- {
- FieldPath: descriptor.FieldPath([]descriptor.FieldPathComponent{
- {
- Name: "nested",
- Target: nestedField,
- },
- {
- Name: "int32",
- Target: intField,
- },
- }),
- Target: intField,
- },
- },
- Body: &descriptor.Body{
- FieldPath: descriptor.FieldPath([]descriptor.FieldPathComponent{
- {
- Name: "nested",
- Target: nestedField,
- },
- {
- Name: "bool",
- Target: boolField,
- },
- }),
- },
- },
- },
- },
- },
- },
- },
- }
- reg := descriptor.NewRegistry()
- if err := AddErrorDefs(reg); err != nil {
- t.Errorf("AddErrorDefs(%#v) failed with %v; want success", reg, err)
- return
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto},
- })
- if err != nil {
- t.Fatalf("failed to load code generator request: %v", err)
- }
- result, err := applyTemplate(param{File: crossLinkFixture(&file), reg: reg})
- if err != nil {
- t.Errorf("applyTemplate(%#v) failed with %v; want success", file, err)
- return
- }
- if want, got := "2.0", result.Swagger; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).Swagger = %s want to be %s", file, got, want)
- }
- if want, got := "", result.BasePath; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).BasePath = %s want to be %s", file, got, want)
- }
- if want, got := ([]string)(nil), result.Schemes; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).Schemes = %s want to be %s", file, got, want)
- }
- if want, got := []string{"application/json"}, result.Consumes; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).Consumes = %s want to be %s", file, got, want)
- }
- if want, got := []string{"application/json"}, result.Produces; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).Produces = %s want to be %s", file, got, want)
- }
- // If there was a failure, print out the input and the json result for debugging.
- if t.Failed() {
- t.Errorf("had: %s", file)
- t.Errorf("got: %s", fmt.Sprint(result))
- }
- }
- func TestApplyTemplateRequestWithClientStreaming(t *testing.T) {
- msgdesc := &descriptorpb.DescriptorProto{
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("nested"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String("NestedMessage"),
- Number: proto.Int32(1),
- },
- },
- }
- nesteddesc := &descriptorpb.DescriptorProto{
- Name: proto.String("NestedMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("int32"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_INT32.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("bool"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_BOOL.Enum(),
- Number: proto.Int32(2),
- },
- },
- }
- meth := &descriptorpb.MethodDescriptorProto{
- Name: proto.String("Echo"),
- InputType: proto.String("ExampleMessage"),
- OutputType: proto.String("ExampleMessage"),
- ClientStreaming: proto.Bool(true),
- ServerStreaming: proto.Bool(true),
- }
- svc := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("ExampleService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- msg := &descriptor.Message{
- DescriptorProto: msgdesc,
- }
- nested := &descriptor.Message{
- DescriptorProto: nesteddesc,
- }
- nestedField := &descriptor.Field{
- Message: msg,
- FieldDescriptorProto: msg.GetField()[0],
- }
- intField := &descriptor.Field{
- Message: nested,
- FieldDescriptorProto: nested.GetField()[0],
- }
- boolField := &descriptor.Field{
- Message: nested,
- FieldDescriptorProto: nested.GetField()[1],
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- MessageType: []*descriptorpb.DescriptorProto{msgdesc, nesteddesc},
- Service: []*descriptorpb.ServiceDescriptorProto{svc},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: []*descriptor.Message{msg, nested},
- Services: []*descriptor.Service{
- {
- ServiceDescriptorProto: svc,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: msg,
- ResponseType: msg,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "POST",
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/echo", // TODO(achew): Figure out what this hsould really be
- },
- PathParams: []descriptor.Parameter{
- {
- FieldPath: descriptor.FieldPath([]descriptor.FieldPathComponent{
- {
- Name: "nested",
- Target: nestedField,
- },
- {
- Name: "int32",
- Target: intField,
- },
- }),
- Target: intField,
- },
- },
- Body: &descriptor.Body{
- FieldPath: descriptor.FieldPath([]descriptor.FieldPathComponent{
- {
- Name: "nested",
- Target: nestedField,
- },
- {
- Name: "bool",
- Target: boolField,
- },
- }),
- },
- },
- },
- },
- },
- },
- },
- }
- reg := descriptor.NewRegistry()
- if err := AddErrorDefs(reg); err != nil {
- t.Errorf("AddErrorDefs(%#v) failed with %v; want success", reg, err)
- return
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto},
- })
- if err != nil {
- t.Fatalf("failed to load code generator request: %v", err)
- }
- result, err := applyTemplate(param{File: crossLinkFixture(&file), reg: reg})
- if err != nil {
- t.Errorf("applyTemplate(%#v) failed with %v; want success", file, err)
- return
- }
- // Only ExampleMessage must be present, not NestedMessage
- if want, got, name := 3, len(result.Definitions), "len(Definitions)"; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %d want to be %d", file, name, got, want)
- }
- if _, ok := result.Paths["/v1/echo"].Post.Responses["200"]; !ok {
- t.Errorf("applyTemplate(%#v).%s = expected 200 response to be defined", file, `result.Paths["/v1/echo"].Post.Responses["200"]`)
- } else {
- if want, got, name := "A successful response.(streaming responses)", result.Paths["/v1/echo"].Post.Responses["200"].Description, `result.Paths["/v1/echo"].Post.Responses["200"].Description`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, got, want)
- }
- streamExampleExampleMessage := result.Paths["/v1/echo"].Post.Responses["200"].Schema
- if want, got, name := "object", streamExampleExampleMessage.Type, `result.Paths["/v1/echo"].Post.Responses["200"].Schema.Type`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, got, want)
- }
- if want, got, name := "Stream result of exampleExampleMessage", streamExampleExampleMessage.Title, `result.Paths["/v1/echo"].Post.Responses["200"].Schema.Title`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, got, want)
- }
- streamExampleExampleMessageProperties := *(streamExampleExampleMessage.Properties)
- if want, got, name := 2, len(streamExampleExampleMessageProperties), `len(StreamDefinitions["exampleExampleMessage"].Properties)`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %d want to be %d", file, name, got, want)
- } else {
- resultProperty := streamExampleExampleMessageProperties[0]
- if want, got, name := "result", resultProperty.Key, `(*(StreamDefinitions["exampleExampleMessage"].Properties))[0].Key`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, got, want)
- }
- result := resultProperty.Value.(openapiSchemaObject)
- if want, got, name := "#/definitions/exampleExampleMessage", result.Ref, `((*(StreamDefinitions["exampleExampleMessage"].Properties))[0].Value.(openapiSchemaObject)).Ref`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, got, want)
- }
- errorProperty := streamExampleExampleMessageProperties[1]
- if want, got, name := "error", errorProperty.Key, `(*(StreamDefinitions["exampleExampleMessage"].Properties))[0].Key`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, got, want)
- }
- err := errorProperty.Value.(openapiSchemaObject)
- if want, got, name := "#/definitions/rpcStatus", err.Ref, `((*(StreamDefinitions["exampleExampleMessage"].Properties))[0].Value.(openapiSchemaObject)).Ref`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %s want to be %s", file, name, got, want)
- }
- }
- }
- // If there was a failure, print out the input and the json result for debugging.
- if t.Failed() {
- t.Errorf("had: %s", file)
- t.Errorf("got: %s", fmt.Sprint(result))
- }
- }
- func TestApplyTemplateRequestWithUnusedReferences(t *testing.T) {
- reqdesc := &descriptorpb.DescriptorProto{
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("string"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- },
- }
- respdesc := &descriptorpb.DescriptorProto{
- Name: proto.String("EmptyMessage"),
- }
- meth := &descriptorpb.MethodDescriptorProto{
- Name: proto.String("Example"),
- InputType: proto.String("ExampleMessage"),
- OutputType: proto.String("EmptyMessage"),
- ClientStreaming: proto.Bool(false),
- ServerStreaming: proto.Bool(false),
- }
- svc := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("ExampleService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- req := &descriptor.Message{
- DescriptorProto: reqdesc,
- }
- resp := &descriptor.Message{
- DescriptorProto: respdesc,
- }
- stringField := &descriptor.Field{
- Message: req,
- FieldDescriptorProto: req.GetField()[0],
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- MessageType: []*descriptorpb.DescriptorProto{reqdesc, respdesc},
- Service: []*descriptorpb.ServiceDescriptorProto{svc},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: []*descriptor.Message{req, resp},
- Services: []*descriptor.Service{
- {
- ServiceDescriptorProto: svc,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: req,
- ResponseType: resp,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "GET",
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/example",
- },
- },
- {
- HTTPMethod: "POST",
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/example/{string}",
- },
- PathParams: []descriptor.Parameter{
- {
- FieldPath: descriptor.FieldPath([]descriptor.FieldPathComponent{
- {
- Name: "string",
- Target: stringField,
- },
- }),
- Target: stringField,
- },
- },
- Body: &descriptor.Body{
- FieldPath: descriptor.FieldPath([]descriptor.FieldPathComponent{
- {
- Name: "string",
- Target: stringField,
- },
- }),
- },
- },
- },
- },
- },
- },
- },
- }
- reg := descriptor.NewRegistry()
- if err := AddErrorDefs(reg); err != nil {
- t.Errorf("AddErrorDefs(%#v) failed with %v; want success", reg, err)
- return
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto},
- })
- if err != nil {
- t.Fatalf("failed to load code generator request: %v", err)
- }
- result, err := applyTemplate(param{File: crossLinkFixture(&file), reg: reg})
- if err != nil {
- t.Errorf("applyTemplate(%#v) failed with %v; want success", file, err)
- return
- }
- // Only EmptyMessage must be present, not ExampleMessage (plus error status)
- if want, got, name := 3, len(result.Definitions), "len(Definitions)"; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %d want to be %d", file, name, got, want)
- }
- // If there was a failure, print out the input and the json result for debugging.
- if t.Failed() {
- t.Errorf("had: %s", file)
- t.Errorf("got: %s", fmt.Sprint(result))
- }
- }
- func TestApplyTemplateRequestWithBodyQueryParameters(t *testing.T) {
- bookDesc := &descriptorpb.DescriptorProto{
- Name: proto.String("Book"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("name"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REQUIRED.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("id"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REQUIRED.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(2),
- },
- },
- }
- createDesc := &descriptorpb.DescriptorProto{
- Name: proto.String("CreateBookRequest"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("parent"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REQUIRED.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("book"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REQUIRED.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(2),
- },
- {
- Name: proto.String("book_id"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REQUIRED.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(3),
- },
- },
- }
- meth := &descriptorpb.MethodDescriptorProto{
- Name: proto.String("CreateBook"),
- InputType: proto.String("CreateBookRequest"),
- OutputType: proto.String("Book"),
- }
- svc := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("BookService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- bookMsg := &descriptor.Message{
- DescriptorProto: bookDesc,
- }
- createMsg := &descriptor.Message{
- DescriptorProto: createDesc,
- }
- parentField := &descriptor.Field{
- Message: createMsg,
- FieldDescriptorProto: createMsg.GetField()[0],
- }
- bookField := &descriptor.Field{
- Message: createMsg,
- FieldMessage: bookMsg,
- FieldDescriptorProto: createMsg.GetField()[1],
- }
- bookIDField := &descriptor.Field{
- Message: createMsg,
- FieldDescriptorProto: createMsg.GetField()[2],
- }
- createMsg.Fields = []*descriptor.Field{parentField, bookField, bookIDField}
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("book.proto"),
- MessageType: []*descriptorpb.DescriptorProto{bookDesc, createDesc},
- Service: []*descriptorpb.ServiceDescriptorProto{svc},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/book.pb",
- Name: "book_pb",
- },
- Messages: []*descriptor.Message{bookMsg, createMsg},
- Services: []*descriptor.Service{
- {
- ServiceDescriptorProto: svc,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: createMsg,
- ResponseType: bookMsg,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "POST",
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/{parent=publishers/*}/books",
- },
- PathParams: []descriptor.Parameter{
- {
- FieldPath: descriptor.FieldPath([]descriptor.FieldPathComponent{
- {
- Name: "parent",
- Target: parentField,
- },
- }),
- Target: parentField,
- },
- },
- Body: &descriptor.Body{
- FieldPath: descriptor.FieldPath([]descriptor.FieldPathComponent{
- {
- Name: "book",
- Target: bookField,
- },
- }),
- },
- },
- },
- },
- },
- },
- },
- }
- reg := descriptor.NewRegistry()
- if err := AddErrorDefs(reg); err != nil {
- t.Errorf("AddErrorDefs(%#v) failed with %v; want success", reg, err)
- return
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto}})
- if err != nil {
- t.Errorf("Registry.Load() failed with %v; want success", err)
- return
- }
- result, err := applyTemplate(param{File: crossLinkFixture(&file), reg: reg})
- if err != nil {
- t.Errorf("applyTemplate(%#v) failed with %v; want success", file, err)
- return
- }
- if _, ok := result.Paths["/v1/{parent=publishers/*}/books"].Post.Responses["200"]; !ok {
- t.Errorf("applyTemplate(%#v).%s = expected 200 response to be defined", file, `result.Paths["/v1/{parent=publishers/*}/books"].Post.Responses["200"]`)
- } else {
- if want, got, name := 3, len(result.Paths["/v1/{parent=publishers/*}/books"].Post.Parameters), `len(result.Paths["/v1/{parent=publishers/*}/books"].Post.Parameters)`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %d want to be %d", file, name, got, want)
- }
- type param struct {
- Name string
- In string
- Required bool
- }
- p0 := result.Paths["/v1/{parent=publishers/*}/books"].Post.Parameters[0]
- if want, got, name := (param{"parent", "path", true}), (param{p0.Name, p0.In, p0.Required}), `result.Paths["/v1/{parent=publishers/*}/books"].Post.Parameters[0]`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %v want to be %v", file, name, got, want)
- }
- p1 := result.Paths["/v1/{parent=publishers/*}/books"].Post.Parameters[1]
- if want, got, name := (param{"body", "body", true}), (param{p1.Name, p1.In, p1.Required}), `result.Paths["/v1/{parent=publishers/*}/books"].Post.Parameters[1]`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %v want to be %v", file, name, got, want)
- }
- p2 := result.Paths["/v1/{parent=publishers/*}/books"].Post.Parameters[2]
- if want, got, name := (param{"book_id", "query", false}), (param{p2.Name, p2.In, p2.Required}), `result.Paths["/v1/{parent=publishers/*}/books"].Post.Parameters[1]`; !reflect.DeepEqual(got, want) {
- t.Errorf("applyTemplate(%#v).%s = %v want to be %v", file, name, got, want)
- }
- }
- // If there was a failure, print out the input and the json result for debugging.
- if t.Failed() {
- t.Errorf("had: %s", file)
- t.Errorf("got: %s", fmt.Sprint(result))
- }
- }
- func generateFieldsForJSONReservedName() []*descriptor.Field {
- fields := make([]*descriptor.Field, 0)
- fieldName := string("json_name")
- fieldJSONName := string("jsonNAME")
- fieldDescriptor := descriptorpb.FieldDescriptorProto{Name: &fieldName, JsonName: &fieldJSONName}
- field := &descriptor.Field{FieldDescriptorProto: &fieldDescriptor}
- return append(fields, field)
- }
- func generateMsgsForJSONReservedName() []*descriptor.Message {
- result := make([]*descriptor.Message, 0)
- // The first message, its field is field_abc and its type is NewType
- // NewType field_abc
- fieldName := "field_abc"
- fieldJSONName := "fieldAbc"
- messageName1 := "message1"
- messageType := "pkg.a.NewType"
- pfd := descriptorpb.FieldDescriptorProto{Name: &fieldName, JsonName: &fieldJSONName, TypeName: &messageType}
- result = append(result,
- &descriptor.Message{
- DescriptorProto: &descriptorpb.DescriptorProto{
- Name: &messageName1, Field: []*descriptorpb.FieldDescriptorProto{&pfd},
- },
- })
- // The second message, its name is NewName, its type is string
- // message NewType {
- // string field_newName [json_name = RESERVEDJSONNAME]
- // }
- messageName := "NewType"
- field := "field_newName"
- fieldJSONName2 := "RESERVEDJSONNAME"
- pfd2 := descriptorpb.FieldDescriptorProto{Name: &field, JsonName: &fieldJSONName2}
- result = append(result, &descriptor.Message{
- DescriptorProto: &descriptorpb.DescriptorProto{
- Name: &messageName, Field: []*descriptorpb.FieldDescriptorProto{&pfd2},
- },
- })
- return result
- }
- func TestTemplateWithJsonCamelCase(t *testing.T) {
- var tests = []struct {
- input string
- expected string
- }{
- {"/test/{test_id}", "/test/{testId}"},
- {"/test1/{test1_id}/test2/{test2_id}", "/test1/{test1Id}/test2/{test2Id}"},
- {"/test1/{test1_id}/{test2_id}", "/test1/{test1Id}/{test2Id}"},
- {"/test1/test2/{test1_id}/{test2_id}", "/test1/test2/{test1Id}/{test2Id}"},
- {"/test1/{test1_id1_id2}", "/test1/{test1Id1Id2}"},
- {"/test1/{test1_id1_id2}/test2/{test2_id3_id4}", "/test1/{test1Id1Id2}/test2/{test2Id3Id4}"},
- {"/test1/test2/{test1_id1_id2}/{test2_id3_id4}", "/test1/test2/{test1Id1Id2}/{test2Id3Id4}"},
- {"test/{a}", "test/{a}"},
- {"test/{ab}", "test/{ab}"},
- {"test/{a_a}", "test/{aA}"},
- {"test/{ab_c}", "test/{abC}"},
- {"test/{json_name}", "test/{jsonNAME}"},
- {"test/{field_abc.field_newName}", "test/{fieldAbc.RESERVEDJSONNAME}"},
- }
- reg := descriptor.NewRegistry()
- reg.SetUseJSONNamesForFields(true)
- for _, data := range tests {
- actual := templateToOpenAPIPath(data.input, reg, generateFieldsForJSONReservedName(), generateMsgsForJSONReservedName())
- if data.expected != actual {
- t.Errorf("Expected templateToOpenAPIPath(%v) = %v, actual: %v", data.input, data.expected, actual)
- }
- }
- }
- func TestTemplateWithoutJsonCamelCase(t *testing.T) {
- var tests = []struct {
- input string
- expected string
- }{
- {"/test/{test_id}", "/test/{test_id}"},
- {"/test1/{test1_id}/test2/{test2_id}", "/test1/{test1_id}/test2/{test2_id}"},
- {"/test1/{test1_id}/{test2_id}", "/test1/{test1_id}/{test2_id}"},
- {"/test1/test2/{test1_id}/{test2_id}", "/test1/test2/{test1_id}/{test2_id}"},
- {"/test1/{test1_id1_id2}", "/test1/{test1_id1_id2}"},
- {"/test1/{test1_id1_id2}/test2/{test2_id3_id4}", "/test1/{test1_id1_id2}/test2/{test2_id3_id4}"},
- {"/test1/test2/{test1_id1_id2}/{test2_id3_id4}", "/test1/test2/{test1_id1_id2}/{test2_id3_id4}"},
- {"test/{a}", "test/{a}"},
- {"test/{ab}", "test/{ab}"},
- {"test/{a_a}", "test/{a_a}"},
- {"test/{json_name}", "test/{json_name}"},
- {"test/{field_abc.field_newName}", "test/{field_abc.field_newName}"},
- }
- reg := descriptor.NewRegistry()
- reg.SetUseJSONNamesForFields(false)
- for _, data := range tests {
- actual := templateToOpenAPIPath(data.input, reg, generateFieldsForJSONReservedName(), generateMsgsForJSONReservedName())
- if data.expected != actual {
- t.Errorf("Expected templateToOpenAPIPath(%v) = %v, actual: %v", data.input, data.expected, actual)
- }
- }
- }
- func TestTemplateToOpenAPIPath(t *testing.T) {
- var tests = []struct {
- input string
- expected string
- }{
- {"/test", "/test"},
- {"/{test}", "/{test}"},
- {"/{test=prefix/*}", "/{test}"},
- {"/{test=prefix/that/has/multiple/parts/to/it/*}", "/{test}"},
- {"/{test1}/{test2}", "/{test1}/{test2}"},
- {"/{test1}/{test2}/", "/{test1}/{test2}/"},
- {"/{name=prefix/*}", "/{name=prefix/*}"},
- {"/{name=prefix1/*/prefix2/*}", "/{name=prefix1/*/prefix2/*}"},
- {"/{user.name=prefix/*}", "/{user.name=prefix/*}"},
- {"/{user.name=prefix1/*/prefix2/*}", "/{user.name=prefix1/*/prefix2/*}"},
- {"/{parent=prefix/*}/children", "/{parent=prefix/*}/children"},
- {"/{name=prefix/*}:customMethod", "/{name=prefix/*}:customMethod"},
- {"/{name=prefix1/*/prefix2/*}:customMethod", "/{name=prefix1/*/prefix2/*}:customMethod"},
- {"/{user.name=prefix/*}:customMethod", "/{user.name=prefix/*}:customMethod"},
- {"/{user.name=prefix1/*/prefix2/*}:customMethod", "/{user.name=prefix1/*/prefix2/*}:customMethod"},
- {"/{parent=prefix/*}/children:customMethod", "/{parent=prefix/*}/children:customMethod"},
- }
- reg := descriptor.NewRegistry()
- reg.SetUseJSONNamesForFields(false)
- for _, data := range tests {
- actual := templateToOpenAPIPath(data.input, reg, generateFieldsForJSONReservedName(), generateMsgsForJSONReservedName())
- if data.expected != actual {
- t.Errorf("Expected templateToOpenAPIPath(%v) = %v, actual: %v", data.input, data.expected, actual)
- }
- }
- reg.SetUseJSONNamesForFields(true)
- for _, data := range tests {
- actual := templateToOpenAPIPath(data.input, reg, generateFieldsForJSONReservedName(), generateMsgsForJSONReservedName())
- if data.expected != actual {
- t.Errorf("Expected templateToOpenAPIPath(%v) = %v, actual: %v", data.input, data.expected, actual)
- }
- }
- }
- func BenchmarkTemplateToOpenAPIPath(b *testing.B) {
- const input = "/{user.name=prefix1/*/prefix2/*}:customMethod"
- b.Run("with JSON names", func(b *testing.B) {
- reg := descriptor.NewRegistry()
- reg.SetUseJSONNamesForFields(false)
- for i := 0; i < b.N; i++ {
- _ = templateToOpenAPIPath(input, reg, generateFieldsForJSONReservedName(), generateMsgsForJSONReservedName())
- }
- })
- b.Run("without JSON names", func(b *testing.B) {
- reg := descriptor.NewRegistry()
- reg.SetUseJSONNamesForFields(true)
- for i := 0; i < b.N; i++ {
- _ = templateToOpenAPIPath(input, reg, generateFieldsForJSONReservedName(), generateMsgsForJSONReservedName())
- }
- })
- }
- func TestResolveFullyQualifiedNameToOpenAPIName(t *testing.T) {
- var tests = []struct {
- input string
- output string
- listOfFQMNs []string
- useFQNForOpenAPIName bool
- }{
- {
- ".a.b.C",
- "C",
- []string{
- ".a.b.C",
- },
- false,
- },
- {
- ".a.b.C",
- "abC",
- []string{
- ".a.C",
- ".a.b.C",
- },
- false,
- },
- {
- ".a.b.C",
- "abC",
- []string{
- ".C",
- ".a.C",
- ".a.b.C",
- },
- false,
- },
- {
- ".a.b.C",
- "a.b.C",
- []string{
- ".C",
- ".a.C",
- ".a.b.C",
- },
- true,
- },
- }
- for _, data := range tests {
- names := resolveFullyQualifiedNameToOpenAPINames(data.listOfFQMNs, data.useFQNForOpenAPIName)
- output := names[data.input]
- if output != data.output {
- t.Errorf("Expected fullyQualifiedNameToOpenAPIName(%v) to be %s but got %s",
- data.input, data.output, output)
- }
- }
- }
- func TestFQMNtoOpenAPIName(t *testing.T) {
- var tests = []struct {
- input string
- expected string
- }{
- {"/test", "/test"},
- {"/{test}", "/{test}"},
- {"/{test=prefix/*}", "/{test}"},
- {"/{test=prefix/that/has/multiple/parts/to/it/*}", "/{test}"},
- {"/{test1}/{test2}", "/{test1}/{test2}"},
- {"/{test1}/{test2}/", "/{test1}/{test2}/"},
- }
- reg := descriptor.NewRegistry()
- reg.SetUseJSONNamesForFields(false)
- for _, data := range tests {
- actual := templateToOpenAPIPath(data.input, reg, generateFieldsForJSONReservedName(), generateMsgsForJSONReservedName())
- if data.expected != actual {
- t.Errorf("Expected templateToOpenAPIPath(%v) = %v, actual: %v", data.input, data.expected, actual)
- }
- }
- reg.SetUseJSONNamesForFields(true)
- for _, data := range tests {
- actual := templateToOpenAPIPath(data.input, reg, generateFieldsForJSONReservedName(), generateMsgsForJSONReservedName())
- if data.expected != actual {
- t.Errorf("Expected templateToOpenAPIPath(%v) = %v, actual: %v", data.input, data.expected, actual)
- }
- }
- }
- func TestSchemaOfField(t *testing.T) {
- type test struct {
- field *descriptor.Field
- refs refMap
- expected openapiSchemaObject
- openAPIOptions *openapiconfig.OpenAPIOptions
- }
- jsonSchema := &openapi_options.JSONSchema{
- Title: "field title",
- Description: "field description",
- }
- var fieldOptions = new(descriptorpb.FieldOptions)
- proto.SetExtension(fieldOptions, openapi_options.E_Openapiv2Field, jsonSchema)
- var requiredField = []annotations.FieldBehavior{annotations.FieldBehavior_REQUIRED}
- var requiredFieldOptions = new(descriptorpb.FieldOptions)
- proto.SetExtension(requiredFieldOptions, annotations.E_FieldBehavior, requiredField)
- var outputOnlyField = []annotations.FieldBehavior{annotations.FieldBehavior_OUTPUT_ONLY}
- var outputOnlyOptions = new(descriptorpb.FieldOptions)
- proto.SetExtension(outputOnlyOptions, annotations.E_FieldBehavior, outputOnlyField)
- tests := []test{
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("primitive_field"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("repeated_primitive_field"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REPEATED.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "array",
- Items: &openapiItemsObject{
- Type: "string",
- },
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.FieldMask"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.Timestamp"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- Format: "date-time",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.Duration"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.StringValue"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("repeated_wrapped_field"),
- TypeName: proto.String(".google.protobuf.StringValue"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REPEATED.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "array",
- Items: &openapiItemsObject{
- Type: "string",
- },
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.BytesValue"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- Format: "byte",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.Int32Value"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "integer",
- Format: "int32",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.UInt32Value"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "integer",
- Format: "int64",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.Int64Value"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- Format: "int64",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.UInt64Value"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- Format: "uint64",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.FloatValue"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "number",
- Format: "float",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.DoubleValue"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "number",
- Format: "double",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.BoolValue"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "boolean",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.Struct"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "object",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.Value"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "object",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.ListValue"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "array",
- Items: (*openapiItemsObject)(&schemaCore{
- Type: "object",
- }),
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("wrapped_field"),
- TypeName: proto.String(".google.protobuf.NullValue"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_ENUM.Enum(),
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("message_field"),
- TypeName: proto.String(".example.Message"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- },
- },
- refs: refMap{".example.Message": struct{}{}},
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Ref: "#/definitions/exampleMessage",
- },
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("map_field"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REPEATED.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.Message.MapFieldEntry"),
- Options: fieldOptions,
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "object",
- },
- AdditionalProperties: &openapiSchemaObject{
- schemaCore: schemaCore{Type: "string"},
- },
- Title: "field title",
- Description: "field description",
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("array_field"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REPEATED.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Options: fieldOptions,
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "array",
- Items: (*openapiItemsObject)(&schemaCore{Type: "string"}),
- },
- Title: "field title",
- Description: "field description",
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("primitive_field"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_INT32.Enum(),
- Options: fieldOptions,
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "integer",
- Format: "int32",
- },
- Title: "field title",
- Description: "field description",
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("message_field"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.Empty"),
- Options: fieldOptions,
- },
- },
- refs: refMap{".example.Empty": struct{}{}},
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Ref: "#/definitions/exampleEmpty",
- },
- Title: "field title",
- Description: "field description",
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("map_field"), // should be called map_field_option but it's not valid map field name
- Label: descriptorpb.FieldDescriptorProto_LABEL_REPEATED.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.Message.MapFieldEntry"),
- },
- },
- openAPIOptions: &openapiconfig.OpenAPIOptions{
- Field: []*openapiconfig.OpenAPIFieldOption{
- {
- Field: "example.Message.map_field",
- Option: jsonSchema,
- },
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "object",
- },
- AdditionalProperties: &openapiSchemaObject{
- schemaCore: schemaCore{Type: "string"},
- },
- Title: "field title",
- Description: "field description",
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("array_field_option"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_REPEATED.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- },
- },
- openAPIOptions: &openapiconfig.OpenAPIOptions{
- Field: []*openapiconfig.OpenAPIFieldOption{
- {
- Field: "example.Message.array_field_option",
- Option: jsonSchema,
- },
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "array",
- Items: (*openapiItemsObject)(&schemaCore{Type: "string"}),
- },
- Title: "field title",
- Description: "field description",
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("primitive_field_option"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_INT32.Enum(),
- },
- },
- openAPIOptions: &openapiconfig.OpenAPIOptions{
- Field: []*openapiconfig.OpenAPIFieldOption{
- {
- Field: "example.Message.primitive_field_option",
- Option: jsonSchema,
- },
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "integer",
- Format: "int32",
- },
- Title: "field title",
- Description: "field description",
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("message_field_option"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- TypeName: proto.String(".example.Empty"),
- },
- },
- openAPIOptions: &openapiconfig.OpenAPIOptions{
- Field: []*openapiconfig.OpenAPIFieldOption{
- {
- Field: "example.Message.message_field_option",
- Option: jsonSchema,
- },
- },
- },
- refs: refMap{".example.Empty": struct{}{}},
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Ref: "#/definitions/exampleEmpty",
- },
- Title: "field title",
- Description: "field description",
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("required_via_field_behavior_field"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Options: requiredFieldOptions,
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- Required: []string{"required_via_field_behavior_field"},
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("readonly_via_field_behavior_field"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Options: outputOnlyOptions,
- },
- },
- refs: make(refMap),
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- ReadOnly: true,
- },
- },
- {
- field: &descriptor.Field{
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: proto.String("message_field"),
- TypeName: proto.String(".example.Message"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_MESSAGE.Enum(),
- Options: requiredFieldOptions,
- },
- },
- refs: refMap{".example.Message": struct{}{}},
- expected: openapiSchemaObject{
- schemaCore: schemaCore{
- Ref: "#/definitions/exampleMessage",
- },
- },
- },
- }
- for _, test := range tests {
- reg := descriptor.NewRegistry()
- req := &pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{
- {
- Name: proto.String("third_party/google.proto"),
- Package: proto.String("google.protobuf"),
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("third_party/google"),
- },
- MessageType: []*descriptorpb.DescriptorProto{
- protodesc.ToDescriptorProto((&structpb.Struct{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&structpb.Value{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&structpb.ListValue{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&field_mask.FieldMask{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((×tamppb.Timestamp{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&durationpb.Duration{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&wrapperspb.StringValue{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&wrapperspb.BytesValue{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&wrapperspb.Int32Value{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&wrapperspb.UInt32Value{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&wrapperspb.Int64Value{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&wrapperspb.UInt64Value{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&wrapperspb.FloatValue{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&wrapperspb.DoubleValue{}).ProtoReflect().Descriptor()),
- protodesc.ToDescriptorProto((&wrapperspb.BoolValue{}).ProtoReflect().Descriptor()),
- },
- EnumType: []*descriptorpb.EnumDescriptorProto{
- protodesc.ToEnumDescriptorProto(structpb.NullValue(0).Descriptor()),
- },
- },
- {
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- Dependency: []string{"third_party/google.proto"},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- MessageType: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("Message"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("value"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- func() *descriptorpb.FieldDescriptorProto {
- fd := test.field.FieldDescriptorProto
- fd.Number = proto.Int32(2)
- return fd
- }(),
- },
- NestedType: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("MapFieldEntry"),
- Options: &descriptorpb.MessageOptions{MapEntry: proto.Bool(true)},
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("key"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- },
- {
- Name: proto.String("value"),
- Label: descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL.Enum(),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(2),
- },
- },
- },
- },
- },
- {
- Name: proto.String("Empty"),
- },
- },
- EnumType: []*descriptorpb.EnumDescriptorProto{
- {
- Name: proto.String("MessageType"),
- Value: []*descriptorpb.EnumValueDescriptorProto{
- {
- Name: proto.String("MESSAGE_TYPE_1"),
- Number: proto.Int32(0),
- },
- },
- },
- },
- Service: []*descriptorpb.ServiceDescriptorProto{},
- },
- },
- }
- err := reg.Load(req)
- if err != nil {
- t.Errorf("failed to reg.Load(req): %v", err)
- }
- // set field's parent message pointer to message so field can resolve its FQFN
- test.field.Message = &descriptor.Message{
- DescriptorProto: req.ProtoFile[1].MessageType[0],
- File: &descriptor.File{
- FileDescriptorProto: req.ProtoFile[1],
- },
- }
- if test.openAPIOptions != nil {
- if err := reg.RegisterOpenAPIOptions(test.openAPIOptions); err != nil {
- t.Fatalf("failed to register OpenAPI options: %s", err)
- }
- }
- refs := make(refMap)
- actual := schemaOfField(test.field, reg, refs)
- expectedSchemaObject := test.expected
- if e, a := expectedSchemaObject, actual; !reflect.DeepEqual(a, e) {
- t.Errorf("Expected schemaOfField(%v) = \n%#+v, actual: \n%#+v", test.field, e, a)
- }
- if !reflect.DeepEqual(refs, test.refs) {
- t.Errorf("Expected schemaOfField(%v) to add refs %v, not %v", test.field, test.refs, refs)
- }
- }
- }
- func TestRenderMessagesAsDefinition(t *testing.T) {
- jsonSchema := &openapi_options.JSONSchema{
- Title: "field title",
- Description: "field description",
- Required: []string{"aRequiredField"},
- }
- var requiredField = new(descriptorpb.FieldOptions)
- proto.SetExtension(requiredField, openapi_options.E_Openapiv2Field, jsonSchema)
- var fieldBehaviorRequired = []annotations.FieldBehavior{annotations.FieldBehavior_REQUIRED}
- var requiredFieldOptions = new(descriptorpb.FieldOptions)
- proto.SetExtension(requiredFieldOptions, annotations.E_FieldBehavior, fieldBehaviorRequired)
- var fieldBehaviorOutputOnlyField = []annotations.FieldBehavior{annotations.FieldBehavior_OUTPUT_ONLY}
- var fieldBehaviorOutputOnlyOptions = new(descriptorpb.FieldOptions)
- proto.SetExtension(fieldBehaviorOutputOnlyOptions, annotations.E_FieldBehavior, fieldBehaviorOutputOnlyField)
- tests := []struct {
- descr string
- msgDescs []*descriptorpb.DescriptorProto
- schema map[string]openapi_options.Schema // per-message schema to add
- defs openapiDefinitionsObject
- openAPIOptions *openapiconfig.OpenAPIOptions
- excludedFields []*descriptor.Field
- }{
- {
- descr: "no OpenAPI options",
- msgDescs: []*descriptorpb.DescriptorProto{
- {Name: proto.String("Message")},
- },
- schema: map[string]openapi_options.Schema{},
- defs: map[string]openapiSchemaObject{
- "Message": {schemaCore: schemaCore{Type: "object"}},
- },
- },
- {
- descr: "example option",
- msgDescs: []*descriptorpb.DescriptorProto{
- {Name: proto.String("Message")},
- },
- schema: map[string]openapi_options.Schema{
- "Message": {
- Example: `{"foo":"bar"}`,
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {schemaCore: schemaCore{
- Type: "object",
- Example: json.RawMessage(`{"foo":"bar"}`),
- }},
- },
- },
- {
- descr: "example option with something non-json",
- msgDescs: []*descriptorpb.DescriptorProto{
- {Name: proto.String("Message")},
- },
- schema: map[string]openapi_options.Schema{
- "Message": {
- Example: `XXXX anything goes XXXX`,
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {schemaCore: schemaCore{
- Type: "object",
- Example: json.RawMessage(`XXXX anything goes XXXX`),
- }},
- },
- },
- {
- descr: "external docs option",
- msgDescs: []*descriptorpb.DescriptorProto{
- {Name: proto.String("Message")},
- },
- schema: map[string]openapi_options.Schema{
- "Message": {
- ExternalDocs: &openapi_options.ExternalDocumentation{
- Description: "glorious docs",
- Url: "https://nada",
- },
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {
- schemaCore: schemaCore{
- Type: "object",
- },
- ExternalDocs: &openapiExternalDocumentationObject{
- Description: "glorious docs",
- URL: "https://nada",
- },
- },
- },
- },
- {
- descr: "JSONSchema options",
- msgDescs: []*descriptorpb.DescriptorProto{
- {Name: proto.String("Message")},
- },
- schema: map[string]openapi_options.Schema{
- "Message": {
- JsonSchema: &openapi_options.JSONSchema{
- Title: "title",
- Description: "desc",
- MultipleOf: 100,
- Maximum: 101,
- ExclusiveMaximum: true,
- Minimum: 1,
- ExclusiveMinimum: true,
- MaxLength: 10,
- MinLength: 3,
- Pattern: "[a-z]+",
- MaxItems: 20,
- MinItems: 2,
- UniqueItems: true,
- MaxProperties: 33,
- MinProperties: 22,
- Required: []string{"req"},
- ReadOnly: true,
- },
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {
- schemaCore: schemaCore{
- Type: "object",
- },
- Title: "title",
- Description: "desc",
- MultipleOf: 100,
- Maximum: 101,
- ExclusiveMaximum: true,
- Minimum: 1,
- ExclusiveMinimum: true,
- MaxLength: 10,
- MinLength: 3,
- Pattern: "[a-z]+",
- MaxItems: 20,
- MinItems: 2,
- UniqueItems: true,
- MaxProperties: 33,
- MinProperties: 22,
- Required: []string{"req"},
- ReadOnly: true,
- },
- },
- },
- {
- descr: "JSONSchema options from registry",
- msgDescs: []*descriptorpb.DescriptorProto{
- {Name: proto.String("Message")},
- },
- openAPIOptions: &openapiconfig.OpenAPIOptions{
- Message: []*openapiconfig.OpenAPIMessageOption{
- {
- Message: "example.Message",
- Option: &openapi_options.Schema{
- JsonSchema: &openapi_options.JSONSchema{
- Title: "title",
- Description: "desc",
- MultipleOf: 100,
- Maximum: 101,
- ExclusiveMaximum: true,
- Minimum: 1,
- ExclusiveMinimum: true,
- MaxLength: 10,
- MinLength: 3,
- Pattern: "[a-z]+",
- MaxItems: 20,
- MinItems: 2,
- UniqueItems: true,
- MaxProperties: 33,
- MinProperties: 22,
- Required: []string{"req"},
- ReadOnly: true,
- },
- },
- },
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {
- schemaCore: schemaCore{
- Type: "object",
- },
- Title: "title",
- Description: "desc",
- MultipleOf: 100,
- Maximum: 101,
- ExclusiveMaximum: true,
- Minimum: 1,
- ExclusiveMinimum: true,
- MaxLength: 10,
- MinLength: 3,
- Pattern: "[a-z]+",
- MaxItems: 20,
- MinItems: 2,
- UniqueItems: true,
- MaxProperties: 33,
- MinProperties: 22,
- Required: []string{"req"},
- ReadOnly: true,
- },
- },
- },
- {
- descr: "JSONSchema with required properties",
- msgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("Message"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("aRequiredField"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- Options: requiredField,
- },
- },
- },
- },
- schema: map[string]openapi_options.Schema{
- "Message": {
- JsonSchema: &openapi_options.JSONSchema{
- Title: "title",
- Description: "desc",
- Required: []string{"req"},
- },
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {
- schemaCore: schemaCore{
- Type: "object",
- },
- Title: "title",
- Description: "desc",
- Required: []string{"req", "aRequiredField"},
- Properties: &openapiSchemaObjectProperties{
- {
- Key: "aRequiredField",
- Value: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- Description: "field description",
- Title: "field title",
- Required: []string{"aRequiredField"},
- },
- },
- },
- },
- },
- },
- {
- descr: "JSONSchema with excluded fields",
- msgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("Message"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("aRequiredField"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- Options: requiredField,
- },
- {
- Name: proto.String("anExcludedField"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(2),
- },
- },
- },
- },
- schema: map[string]openapi_options.Schema{
- "Message": {
- JsonSchema: &openapi_options.JSONSchema{
- Title: "title",
- Description: "desc",
- Required: []string{"req"},
- },
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {
- schemaCore: schemaCore{
- Type: "object",
- },
- Title: "title",
- Description: "desc",
- Required: []string{"req", "aRequiredField"},
- Properties: &openapiSchemaObjectProperties{
- {
- Key: "aRequiredField",
- Value: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- Description: "field description",
- Title: "field title",
- Required: []string{"aRequiredField"},
- },
- },
- },
- },
- },
- excludedFields: []*descriptor.Field{
- {
- FieldDescriptorProto: &descriptorpb.FieldDescriptorProto{
- Name: strPtr("anExcludedField"),
- },
- },
- },
- },
- {
- descr: "JSONSchema with required properties via field_behavior",
- msgDescs: []*descriptorpb.DescriptorProto{
- {
- Name: proto.String("Message"),
- Field: []*descriptorpb.FieldDescriptorProto{
- {
- Name: proto.String("aRequiredField"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(1),
- Options: requiredFieldOptions,
- },
- {
- Name: proto.String("aOutputOnlyField"),
- Type: descriptorpb.FieldDescriptorProto_TYPE_STRING.Enum(),
- Number: proto.Int32(2),
- Options: fieldBehaviorOutputOnlyOptions,
- },
- },
- },
- },
- schema: map[string]openapi_options.Schema{
- "Message": {
- JsonSchema: &openapi_options.JSONSchema{
- Title: "title",
- Description: "desc",
- Required: []string{"req"},
- },
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {
- schemaCore: schemaCore{
- Type: "object",
- },
- Title: "title",
- Description: "desc",
- Required: []string{"req", "aRequiredField"},
- Properties: &openapiSchemaObjectProperties{
- {
- Key: "aRequiredField",
- Value: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- Required: []string{"aRequiredField"},
- },
- },
- {
- Key: "aOutputOnlyField",
- Value: openapiSchemaObject{
- schemaCore: schemaCore{
- Type: "string",
- },
- ReadOnly: true,
- },
- },
- },
- },
- },
- },
- }
- for _, test := range tests {
- t.Run(test.descr, func(t *testing.T) {
- msgs := []*descriptor.Message{}
- for _, msgdesc := range test.msgDescs {
- msgdesc.Options = &descriptorpb.MessageOptions{}
- msgs = append(msgs, &descriptor.Message{DescriptorProto: msgdesc})
- }
- reg := descriptor.NewRegistry()
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- Dependency: []string{},
- MessageType: test.msgDescs,
- EnumType: []*descriptorpb.EnumDescriptorProto{},
- Service: []*descriptorpb.ServiceDescriptorProto{},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- Messages: msgs,
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto},
- })
- if err != nil {
- t.Fatalf("failed to load code generator request: %v", err)
- }
- msgMap := map[string]*descriptor.Message{}
- for _, d := range test.msgDescs {
- name := d.GetName()
- msg, err := reg.LookupMsg("example", name)
- if err != nil {
- t.Fatalf("lookup message %v: %v", name, err)
- }
- msgMap[msg.FQMN()] = msg
- if schema, ok := test.schema[name]; ok {
- proto.SetExtension(d.Options, openapi_options.E_Openapiv2Schema, &schema)
- }
- }
- if test.openAPIOptions != nil {
- if err := reg.RegisterOpenAPIOptions(test.openAPIOptions); err != nil {
- t.Fatalf("failed to register OpenAPI options: %s", err)
- }
- }
- refs := make(refMap)
- actual := make(openapiDefinitionsObject)
- renderMessagesAsDefinition(msgMap, actual, reg, refs, test.excludedFields)
- if !reflect.DeepEqual(actual, test.defs) {
- t.Errorf("Expected renderMessagesAsDefinition() to add defs %+v, not %+v", test.defs, actual)
- }
- })
- }
- }
- func strPtr(s string) *string {
- return &s
- }
- func TestUpdateOpenAPIDataFromComments(t *testing.T) {
- tests := []struct {
- descr string
- openapiSwaggerObject interface{}
- comments string
- expectedError error
- expectedOpenAPIObject interface{}
- useGoTemplate bool
- }{
- {
- descr: "empty comments",
- openapiSwaggerObject: nil,
- expectedOpenAPIObject: nil,
- comments: "",
- expectedError: nil,
- },
- {
- descr: "set field to read only",
- openapiSwaggerObject: &openapiSchemaObject{},
- expectedOpenAPIObject: &openapiSchemaObject{
- ReadOnly: true,
- Description: "... Output only. ...",
- },
- comments: "... Output only. ...",
- expectedError: nil,
- },
- {
- descr: "set title",
- openapiSwaggerObject: &openapiSchemaObject{},
- expectedOpenAPIObject: &openapiSchemaObject{
- Title: "Comment with no trailing dot",
- },
- comments: "Comment with no trailing dot",
- expectedError: nil,
- },
- {
- descr: "set description",
- openapiSwaggerObject: &openapiSchemaObject{},
- expectedOpenAPIObject: &openapiSchemaObject{
- Description: "Comment with trailing dot.",
- },
- comments: "Comment with trailing dot.",
- expectedError: nil,
- },
- {
- descr: "use info object",
- openapiSwaggerObject: &openapiSwaggerObject{
- Info: openapiInfoObject{},
- },
- expectedOpenAPIObject: &openapiSwaggerObject{
- Info: openapiInfoObject{
- Description: "Comment with trailing dot.",
- },
- },
- comments: "Comment with trailing dot.",
- expectedError: nil,
- },
- {
- descr: "multi line comment with title",
- openapiSwaggerObject: &openapiSchemaObject{},
- expectedOpenAPIObject: &openapiSchemaObject{
- Title: "First line",
- Description: "Second line",
- },
- comments: "First line\n\nSecond line",
- expectedError: nil,
- },
- {
- descr: "multi line comment no title",
- openapiSwaggerObject: &openapiSchemaObject{},
- expectedOpenAPIObject: &openapiSchemaObject{
- Description: "First line.\n\nSecond line",
- },
- comments: "First line.\n\nSecond line",
- expectedError: nil,
- },
- {
- descr: "multi line comment with summary with dot",
- openapiSwaggerObject: &openapiOperationObject{},
- expectedOpenAPIObject: &openapiOperationObject{
- Summary: "First line.",
- Description: "Second line",
- },
- comments: "First line.\n\nSecond line",
- expectedError: nil,
- },
- {
- descr: "multi line comment with summary no dot",
- openapiSwaggerObject: &openapiOperationObject{},
- expectedOpenAPIObject: &openapiOperationObject{
- Summary: "First line",
- Description: "Second line",
- },
- comments: "First line\n\nSecond line",
- expectedError: nil,
- },
- {
- descr: "multi line comment with summary no dot",
- openapiSwaggerObject: &schemaCore{},
- expectedOpenAPIObject: &schemaCore{},
- comments: "Any comment",
- expectedError: errors.New("no description nor summary property"),
- },
- {
- descr: "without use_go_template",
- openapiSwaggerObject: &openapiSchemaObject{},
- expectedOpenAPIObject: &openapiSchemaObject{
- Title: "First line",
- Description: "{{import \"documentation.md\"}}",
- },
- comments: "First line\n\n{{import \"documentation.md\"}}",
- expectedError: nil,
- },
- {
- descr: "error with use_go_template",
- openapiSwaggerObject: &openapiSchemaObject{},
- expectedOpenAPIObject: &openapiSchemaObject{
- Title: "First line",
- Description: "open noneexistingfile.txt: no such file or directory",
- },
- comments: "First line\n\n{{import \"noneexistingfile.txt\"}}",
- expectedError: nil,
- useGoTemplate: true,
- },
- {
- descr: "template with use_go_template",
- openapiSwaggerObject: &openapiSchemaObject{},
- expectedOpenAPIObject: &openapiSchemaObject{
- Title: "Template",
- Description: `Description "which means nothing"`,
- },
- comments: "Template\n\nDescription {{with \"which means nothing\"}}{{printf \"%q\" .}}{{end}}",
- expectedError: nil,
- useGoTemplate: true,
- },
- }
- for _, test := range tests {
- t.Run(test.descr, func(t *testing.T) {
- reg := descriptor.NewRegistry()
- if test.useGoTemplate {
- reg.SetUseGoTemplate(true)
- }
- err := updateOpenAPIDataFromComments(reg, test.openapiSwaggerObject, nil, test.comments, false)
- if test.expectedError == nil {
- if err != nil {
- t.Errorf("unexpected error '%v'", err)
- }
- if !reflect.DeepEqual(test.openapiSwaggerObject, test.expectedOpenAPIObject) {
- t.Errorf("openapiSwaggerObject was not updated correctly, expected '%+v', got '%+v'", test.expectedOpenAPIObject, test.openapiSwaggerObject)
- }
- } else {
- if err == nil {
- t.Error("expected update error not returned")
- }
- if !reflect.DeepEqual(test.openapiSwaggerObject, test.expectedOpenAPIObject) {
- t.Errorf("openapiSwaggerObject was not updated correctly, expected '%+v', got '%+v'", test.expectedOpenAPIObject, test.openapiSwaggerObject)
- }
- if err.Error() != test.expectedError.Error() {
- t.Errorf("expected error malformed, expected %q, got %q", test.expectedError.Error(), err.Error())
- }
- }
- })
- }
- }
- func TestMessageOptionsWithGoTemplate(t *testing.T) {
- tests := []struct {
- descr string
- msgDescs []*descriptorpb.DescriptorProto
- schema map[string]openapi_options.Schema // per-message schema to add
- defs openapiDefinitionsObject
- openAPIOptions *openapiconfig.OpenAPIOptions
- useGoTemplate bool
- }{
- {
- descr: "external docs option",
- msgDescs: []*descriptorpb.DescriptorProto{
- {Name: proto.String("Message")},
- },
- schema: map[string]openapi_options.Schema{
- "Message": {
- JsonSchema: &openapi_options.JSONSchema{
- Title: "{{.Name}}",
- Description: "Description {{with \"which means nothing\"}}{{printf \"%q\" .}}{{end}}",
- },
- ExternalDocs: &openapi_options.ExternalDocumentation{
- Description: "Description {{with \"which means nothing\"}}{{printf \"%q\" .}}{{end}}",
- },
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {
- schemaCore: schemaCore{
- Type: "object",
- },
- Title: "Message",
- Description: `Description "which means nothing"`,
- ExternalDocs: &openapiExternalDocumentationObject{
- Description: `Description "which means nothing"`,
- },
- },
- },
- useGoTemplate: true,
- },
- {
- descr: "external docs option",
- msgDescs: []*descriptorpb.DescriptorProto{
- {Name: proto.String("Message")},
- },
- schema: map[string]openapi_options.Schema{
- "Message": {
- JsonSchema: &openapi_options.JSONSchema{
- Title: "{{.Name}}",
- Description: "Description {{with \"which means nothing\"}}{{printf \"%q\" .}}{{end}}",
- },
- ExternalDocs: &openapi_options.ExternalDocumentation{
- Description: "Description {{with \"which means nothing\"}}{{printf \"%q\" .}}{{end}}",
- },
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {
- schemaCore: schemaCore{
- Type: "object",
- },
- Title: "{{.Name}}",
- Description: "Description {{with \"which means nothing\"}}{{printf \"%q\" .}}{{end}}",
- ExternalDocs: &openapiExternalDocumentationObject{
- Description: "Description {{with \"which means nothing\"}}{{printf \"%q\" .}}{{end}}",
- },
- },
- },
- useGoTemplate: false,
- },
- {
- descr: "registered OpenAPIOption",
- msgDescs: []*descriptorpb.DescriptorProto{
- {Name: proto.String("Message")},
- },
- openAPIOptions: &openapiconfig.OpenAPIOptions{
- Message: []*openapiconfig.OpenAPIMessageOption{
- {
- Message: "example.Message",
- Option: &openapi_options.Schema{
- JsonSchema: &openapi_options.JSONSchema{
- Title: "{{.Name}}",
- Description: "Description {{with \"which means nothing\"}}{{printf \"%q\" .}}{{end}}",
- },
- ExternalDocs: &openapi_options.ExternalDocumentation{
- Description: "Description {{with \"which means nothing\"}}{{printf \"%q\" .}}{{end}}",
- },
- },
- },
- },
- },
- defs: map[string]openapiSchemaObject{
- "Message": {
- schemaCore: schemaCore{
- Type: "object",
- },
- Title: "Message",
- Description: `Description "which means nothing"`,
- ExternalDocs: &openapiExternalDocumentationObject{
- Description: `Description "which means nothing"`,
- },
- },
- },
- useGoTemplate: true,
- },
- }
- for _, test := range tests {
- t.Run(test.descr, func(t *testing.T) {
- msgs := []*descriptor.Message{}
- for _, msgdesc := range test.msgDescs {
- msgdesc.Options = &descriptorpb.MessageOptions{}
- msgs = append(msgs, &descriptor.Message{DescriptorProto: msgdesc})
- }
- reg := descriptor.NewRegistry()
- reg.SetUseGoTemplate(test.useGoTemplate)
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- Dependency: []string{},
- MessageType: test.msgDescs,
- EnumType: []*descriptorpb.EnumDescriptorProto{},
- Service: []*descriptorpb.ServiceDescriptorProto{},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- Messages: msgs,
- }
- err := reg.Load(&pluginpb.CodeGeneratorRequest{
- ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto},
- })
- if err != nil {
- t.Fatalf("failed to load code generator request: %v", err)
- }
- msgMap := map[string]*descriptor.Message{}
- for _, d := range test.msgDescs {
- name := d.GetName()
- msg, err := reg.LookupMsg("example", name)
- if err != nil {
- t.Fatalf("lookup message %v: %v", name, err)
- }
- msgMap[msg.FQMN()] = msg
- if schema, ok := test.schema[name]; ok {
- proto.SetExtension(d.Options, openapi_options.E_Openapiv2Schema, &schema)
- }
- }
- if test.openAPIOptions != nil {
- if err := reg.RegisterOpenAPIOptions(test.openAPIOptions); err != nil {
- t.Fatalf("failed to register OpenAPI options: %s", err)
- }
- }
- refs := make(refMap)
- actual := make(openapiDefinitionsObject)
- renderMessagesAsDefinition(msgMap, actual, reg, refs, nil)
- if !reflect.DeepEqual(actual, test.defs) {
- t.Errorf("Expected renderMessagesAsDefinition() to add defs %+v, not %+v", test.defs, actual)
- }
- })
- }
- }
- func TestTemplateWithoutErrorDefinition(t *testing.T) {
- msgdesc := &descriptorpb.DescriptorProto{
- Name: proto.String("ExampleMessage"),
- Field: []*descriptorpb.FieldDescriptorProto{},
- }
- meth := &descriptorpb.MethodDescriptorProto{
- Name: proto.String("Echo"),
- InputType: proto.String("ExampleMessage"),
- OutputType: proto.String("ExampleMessage"),
- }
- svc := &descriptorpb.ServiceDescriptorProto{
- Name: proto.String("ExampleService"),
- Method: []*descriptorpb.MethodDescriptorProto{meth},
- }
- msg := &descriptor.Message{
- DescriptorProto: msgdesc,
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- MessageType: []*descriptorpb.DescriptorProto{msgdesc},
- Service: []*descriptorpb.ServiceDescriptorProto{svc},
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- GoPkg: descriptor.GoPackage{
- Path: "example.com/path/to/example/example.pb",
- Name: "example_pb",
- },
- Messages: []*descriptor.Message{msg},
- Services: []*descriptor.Service{
- {
- ServiceDescriptorProto: svc,
- Methods: []*descriptor.Method{
- {
- MethodDescriptorProto: meth,
- RequestType: msg,
- ResponseType: msg,
- Bindings: []*descriptor.Binding{
- {
- HTTPMethod: "POST",
- PathTmpl: httprule.Template{
- Version: 1,
- OpCodes: []int{0, 0},
- Template: "/v1/echo",
- },
- Body: &descriptor.Body{
- FieldPath: descriptor.FieldPath([]descriptor.FieldPathComponent{}),
- },
- },
- },
- },
- },
- },
- },
- }
- reg := descriptor.NewRegistry()
- err := reg.Load(&pluginpb.CodeGeneratorRequest{ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto}})
- if err != nil {
- t.Errorf("failed to reg.Load(): %v", err)
- return
- }
- result, err := applyTemplate(param{File: crossLinkFixture(&file), reg: reg})
- if err != nil {
- t.Errorf("applyTemplate(%#v) failed with %v; want success", file, err)
- return
- }
- defRsp, ok := result.Paths["/v1/echo"].Post.Responses["default"]
- if !ok {
- return
- }
- ref := defRsp.Schema.schemaCore.Ref
- refName := strings.TrimPrefix(ref, "#/definitions/")
- if refName == "" {
- t.Fatal("created default Error response with empty reflink")
- }
- if _, ok := result.Definitions[refName]; !ok {
- t.Errorf("default Error response with reflink '%v', but its definition was not found", refName)
- }
- }
- func Test_getReservedJsonName(t *testing.T) {
- type args struct {
- fieldName string
- messageNameToFieldsToJSONName map[string]map[string]string
- fieldNameToType map[string]string
- }
- tests := []struct {
- name string
- args args
- want string
- }{
- {
- "test case 1: single dot use case",
- args{
- fieldName: "abc.a_1",
- messageNameToFieldsToJSONName: map[string]map[string]string{
- "Msg": {
- "a_1": "a1JSONNAME",
- "b_1": "b1JSONNAME",
- },
- },
- fieldNameToType: map[string]string{
- "abc": "pkg1.test.Msg",
- "bcd": "pkg1.test.Msg",
- },
- },
- "a1JSONNAME",
- },
- {
- "test case 2: single dot use case with no existing field",
- args{
- fieldName: "abc.d_1",
- messageNameToFieldsToJSONName: map[string]map[string]string{
- "Msg": {
- "a_1": "a1JSONNAME",
- "b_1": "b1JSONNAME",
- },
- },
- fieldNameToType: map[string]string{
- "abc": "pkg1.test.Msg",
- "bcd": "pkg1.test.Msg",
- },
- },
- "",
- },
- {
- "test case 3: double dot use case",
- args{
- fieldName: "pkg.abc.a_1",
- messageNameToFieldsToJSONName: map[string]map[string]string{
- "Msg": {
- "a_1": "a1JSONNAME",
- "b_1": "b1JSONNAME",
- },
- },
- fieldNameToType: map[string]string{
- "abc": "pkg1.test.Msg",
- "bcd": "pkg1.test.Msg",
- },
- },
- "a1JSONNAME",
- },
- {
- "test case 4: double dot use case with a not existed field",
- args{
- fieldName: "pkg.abc.c_1",
- messageNameToFieldsToJSONName: map[string]map[string]string{
- "Msg": {
- "a_1": "a1JSONNAME",
- "b_1": "b1JSONNAME",
- },
- },
- fieldNameToType: map[string]string{
- "abc": "pkg1.test.Msg",
- "bcd": "pkg1.test.Msg",
- },
- },
- "",
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- if got := getReservedJSONName(tt.args.fieldName, tt.args.messageNameToFieldsToJSONName, tt.args.fieldNameToType); got != tt.want {
- t.Errorf("getReservedJSONName() = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestParseIncompleteSecurityRequirement(t *testing.T) {
- swagger := openapi_options.Swagger{
- Security: []*openapi_options.SecurityRequirement{
- {
- SecurityRequirement: map[string]*openapi_options.SecurityRequirement_SecurityRequirementValue{
- "key": nil,
- },
- },
- },
- }
- file := descriptor.File{
- FileDescriptorProto: &descriptorpb.FileDescriptorProto{
- SourceCodeInfo: &descriptorpb.SourceCodeInfo{},
- Name: proto.String("example.proto"),
- Package: proto.String("example"),
- Options: &descriptorpb.FileOptions{
- GoPackage: proto.String("github.com/grpc-ecosystem/grpc-gateway/runtime/internal/examplepb;example"),
- },
- },
- }
- proto.SetExtension(proto.Message(file.FileDescriptorProto.Options), openapi_options.E_Openapiv2Swagger, &swagger)
- reg := descriptor.NewRegistry()
- err := reg.Load(&pluginpb.CodeGeneratorRequest{ProtoFile: []*descriptorpb.FileDescriptorProto{file.FileDescriptorProto}})
- if err != nil {
- t.Errorf("failed to reg.Load(): %v", err)
- return
- }
- _, err = applyTemplate(param{File: crossLinkFixture(&file), reg: reg})
- if err == nil {
- t.Errorf("applyTemplate(%#v) did not error as expected", file)
- return
- }
- }
|